Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#21723 closed defect (bug) (fixed)

Twenty Twelve: Add permalink for image posts without a title

Reported by: obenland Owned by: lancewillett
Priority: normal Milestone: 3.5
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Appart from occasionally missing the date as described in #21721, Image posts may also miss a permalink to the single view, when they have no title.

An easy way to address this would be to wrap the post date in <time> markup and add the permalink, similar to how twentytwelve_entry_meta() does it.

Attachments (3)

21723.diff​ (820 bytes ) - added by obenland 14 years ago.
21723.2.diff​ (853 bytes ) - added by obenland 14 years ago.
21723.3.diff​ (1.4 KB ) - added by lancewillett 14 years ago.

Download all attachments as: .zip

Change History (6)

#1 @nacin
14 years ago

  • Milestone Awaiting Review → 3.5

#2 @lancewillett
14 years ago

Patch is a good start, but I think needs better escaping like esc_attr( get_the_time() ) in the title attribute.

#3 @lancewillett
14 years ago

  • Owner set to lancewillett
  • Resolution → fixed
  • Status new → closed

In [21674]:

Twenty Twelve: add a better permalink markup structure to content-image.php template, for usability when image posts have no title. Props obenland, fixes #21723.

Note: See TracTickets for help on using tickets.