WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#21723 closed defect (bug) (fixed)

Twenty Twelve: Add permalink for image posts without a title

Reported by: obenland Owned by: lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Appart from occasionally missing the date as described in #21721, Image posts may also miss a permalink to the single view, when they have no title.

An easy way to address this would be to wrap the post date in <time> markup and add the permalink, similar to how twentytwelve_entry_meta() does it.

Attachments (3)

21723.diff (820 bytes) - added by obenland 3 years ago.
21723.2.diff (853 bytes) - added by obenland 3 years ago.
21723.3.diff (1.4 KB) - added by lancewillett 3 years ago.

Download all attachments as: .zip

Change History (6)

@obenland3 years ago

comment:1 @nacin3 years ago

  • Milestone changed from Awaiting Review to 3.5

comment:2 @lancewillett3 years ago

Patch is a good start, but I think needs better escaping like esc_attr( get_the_time() ) in the title attribute.

@obenland3 years ago

@lancewillett3 years ago

comment:3 @lancewillett3 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21674]:

Twenty Twelve: add a better permalink markup structure to content-image.php template, for usability when image posts have no title. Props obenland, fixes #21723.

Note: See TracTickets for help on using tickets.