WordPress.org

Make WordPress Core

#21728 closed defect (bug) (fixed)

Consolidate some strings related to user login

Reported by: pavelevap Owned by:
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.4.1
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See attached patch. These corrected strings have two variants only with small changes. As a result of suggested unification, we can remove several similar strings.

Attachments (3)

user_strings.patch (3.8 KB) - added by pavelevap 20 months ago.
21728.patch (4.8 KB) - added by SergeyBiryukov 20 months ago.
21728.2.patch (8.2 KB) - added by pavelevap 19 months ago.

Download all attachments as: .zip

Change History (10)

pavelevap20 months ago

comment:1 SergeyBiryukov20 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.5

comment:2 ocean9020 months ago

e-mail vs email: #14366

SergeyBiryukov20 months ago

comment:3 SergeyBiryukov20 months ago

<strong>ERROR</strong>: The e-mail address isn&#8217;t correct.
<strong>ERROR</strong>: The email address isn&#8217;t correct.

One of these strings is in admin-$locale.po, the other one is in $locale.po. I guess they will remain in both files. However, there's a similar string in admin-$locale.po that can be merged:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/includes/ms.php#L225

Added in 21728.patch. "e-mail" vs. "email" is currently inconsistent, but that can be left for #14366.

The requested user does not exist.
That user does not exist.

Please enter a correct email address.
Please enter a valid email address.

<strong>ERROR</strong>: This username is already registered, please choose another one.
<strong>ERROR</strong>: This username is already registered. Please choose another one.

Same as above, they're in different files. I guess it still might make sense to consolidate them for easier translation.

comment:4 pavelevap20 months ago

Thank you, Sergey! I did not notice this string in MS admin.

I think that merged strings will remain only in one file, see related ticket #20881.

Yes, the main purpose of this ticket was not problem "email" versus "e-mail", but only one small step to consolidate similar strings and make translators a little happier...

pavelevap19 months ago

comment:5 pavelevap19 months ago

Patch updated, there are more strings to remove...

comment:6 ryan19 months ago

In [22124]:

Consolidate some strings. Props pavelevap, SergeyBiryukov. see #21728

comment:7 ryan18 months ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.