#21732 closed defect (bug) (fixed)
Theme customizer: Background attachment selector has no effect in the customizer
Reported by: | johnbillion | Owned by: | duck_ |
---|---|---|---|
Milestone: | 3.5 | Priority: | normal |
Severity: | normal | Version: | 3.4.1 |
Component: | Customize | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description
Changing between fixed/scroll has no effect in the customizer, but it does change the background attachment value when you save it and view your site for real.
Attachments (1)
Change History (7)
#1
@
12 years ago
- Component changed from Themes to Appearance
- Milestone changed from Awaiting Review to 3.5
#2
@
12 years ago
- Cc admin@… added
I took a crack at it and in the customize-preview.js line 132 it's
background-position: top
instead of:
background-attachment:
So i created a quick patch ,tested it a bit and it looks good.
#4
@
12 years ago
- Owner set to duck_
- Resolution set to fixed
- Status changed from new to closed
In [22131]:
#5
follow-up:
↓ 6
@
12 years ago
Thanks for the patch bainternet! Just a couple of notes for the future:
- Don't worry about updating minified JS/CSS
- Patching from the root of the trunk checkout is preferred, so
svn diff
in /path/to/trunk/ instead of /path/to/trunk/wp-includes/js/
#6
in reply to:
↑ 5
@
12 years ago
Replying to duck_:
Thanks for the patch bainternet! Just a couple of notes for the future:
- Don't worry about updating minified JS/CSS
- Patching from the root of the trunk checkout is preferred, so
svn diff
in /path/to/trunk/ instead of /path/to/trunk/wp-includes/js/
Gotcha :)
Note: See
TracTickets for help on using
tickets.
customize-preview.js and customize-preview.min.js patch