WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#21732 closed defect (bug) (fixed)

Theme customizer: Background attachment selector has no effect in the customizer

Reported by: johnbillion Owned by: duck_
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.4.1
Component: Customize Keywords: has-patch needs-testing
Focuses: Cc:

Description

Changing between fixed/scroll has no effect in the customizer, but it does change the background attachment value when you save it and view your site for real.

Attachments (1)

patch.diff (4.6 KB) - added by bainternet 2 years ago.
customize-preview.js and customize-preview.min.js patch

Download all attachments as: .zip

Change History (7)

comment:1 @nacin3 years ago

  • Component changed from Themes to Appearance
  • Milestone changed from Awaiting Review to 3.5

@bainternet2 years ago

customize-preview.js and customize-preview.min.js patch

comment:2 @bainternet2 years ago

  • Cc admin@… added

I took a crack at it and in the customize-preview.js line 132 it's

background-position: top


instead of:

background-attachment:

So i created a quick patch ,tested it a bit and it looks good.

comment:3 @bainternet2 years ago

  • Keywords has-patch needs-testing added

comment:4 @duck_2 years ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from new to closed

In [22131]:

Theme Customizer: Correctly update background-attachment property in live preview

Props bainternet. Fixes #21732.

comment:5 follow-up: @duck_2 years ago

Thanks for the patch bainternet! Just a couple of notes for the future:

  1. Don't worry about updating minified JS/CSS
  2. Patching from the root of the trunk checkout is preferred, so svn diff in /path/to/trunk/ instead of /path/to/trunk/wp-includes/js/

comment:6 in reply to: ↑ 5 @bainternet2 years ago

Replying to duck_:

Thanks for the patch bainternet! Just a couple of notes for the future:

  1. Don't worry about updating minified JS/CSS
  2. Patching from the root of the trunk checkout is preferred, so svn diff in /path/to/trunk/ instead of /path/to/trunk/wp-includes/js/

Gotcha :)

Note: See TracTickets for help on using tickets.