Make WordPress Core

Opened 3 years ago

Last modified 8 weeks ago

#21734 reopened enhancement

Completely remove global terms

Reported by: scribu Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Taxonomy Keywords: needs-refresh
Focuses: Cc:

Description (last modified by scribu)

It's an obscure WPMU feature that 1) hasn't been maintained 2) hardly anyone uses and 3) slows down development on the regular taxonomy code:

#5809 #18609 #18617

There isn't much code to remove, but the idea is to not have to worry about "global terms" anymore at all.

Attachments (4)

21734.diff (14.3 KB) - added by scribu 3 years ago.
remove-global-terms.diff (15.8 KB) - added by wonderboymusic 3 years ago.
21734.2.diff (15.8 KB) - added by scribu 3 years ago.
remove-global-terms-for-plugin.diff (16.1 KB) - added by wonderboymusic 3 years ago.

Download all attachments as: .zip

Change History (19)

3 years ago

#2 @scribu
3 years ago

  • Keywords has-patch added

21734.diff takes care of the raw code removal.

To be completely back-compat, we'd need to automatically install a plugin, when upgrading a WPMU network which had global terms enabled.

#3 @wonderboymusic
3 years ago

whoops - I added a patch at basically the exact same time

#4 @scribu
3 years ago

  • Description modified (diff)

3 years ago

#5 @scribu
3 years ago

21734.2.diff resurrects global_terms_enabled() and adds TODO for where the code for installing the plugin should go.

#6 @wonderboymusic
3 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 3.5

Patch refreshed to accomodate plugin, which now here: http://plugins.svn.wordpress.org/global-terms/trunk/global-terms.php (first rev, needs love / testing)

Version 0, edited 3 years ago by wonderboymusic (next)

#7 follow-up: @scribu
3 years ago

Why is the change in get_blog_permalink() needed?

$link = set_url_scheme( get_permalink( $post_id ) , 'http' );

#8 in reply to: ↑ 7 @SergeyBiryukov
3 years ago

Replying to scribu:

Why is the change in get_blog_permalink() needed?

That was from ticket:19420:blog-perma-set-url-scheme.diff on #19420.

#9 @nacin
3 years ago

  • Keywords punt added

Not sure I have the stomach for this right now. It's fairly unobtrusive code that we've not needed to maintain or touch since we disabled global terms by default in 3.0.

#10 @scribu
3 years ago

  • Keywords punt removed
  • Milestone changed from 3.5 to Future Release

If it doesn't block #5809, I'm fine with it.

#11 @kawauso
3 years ago

  • Cc kawauso added

#12 @wonderboymusic
2 years ago

  • Keywords needs-refresh added; has-patch needs-testing removed
  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed

I don't think this matters right now

#13 @pento
4 months ago

  • Milestone set to Future Release
  • Resolution maybelater deleted
  • Status changed from closed to reopened

Global terms is a buggy hell hole, and I think term splitting broke it, at least on WP.com.

Because no-one in their right mind uses it, let's remove it, and auto-install the plugin on upgrade.

#14 @DrewAPicture
8 weeks ago

@pento Is this still in pursuit?

#15 @pento
8 weeks ago

Yep, we'll hopefully have a plan for WP.com after next week, which will guide how we remove it from Core.

Note: See TracTickets for help on using tickets.