WordPress.org

Make WordPress Core

Opened 20 months ago

Closed 8 months ago

#21734 closed enhancement (maybelater)

Completely remove global terms

Reported by: scribu Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Taxonomy Keywords: needs-refresh
Focuses: Cc:

Description (last modified by scribu)

It's an obscure WPMU feature that 1) hasn't been maintained 2) hardly anyone uses and 3) slows down development on the regular taxonomy code:

#5809 #18609 #18617

There isn't much code to remove, but the idea is to not have to worry about "global terms" anymore at all.

Attachments (4)

21734.diff (14.3 KB) - added by scribu 20 months ago.
remove-global-terms.diff (15.8 KB) - added by wonderboymusic 20 months ago.
21734.2.diff (15.8 KB) - added by scribu 20 months ago.
remove-global-terms-for-plugin.diff (16.1 KB) - added by wonderboymusic 19 months ago.

Download all attachments as: .zip

Change History (16)

scribu20 months ago

comment:2 scribu20 months ago

  • Keywords has-patch added

21734.diff takes care of the raw code removal.

To be completely back-compat, we'd need to automatically install a plugin, when upgrading a WPMU network which had global terms enabled.

comment:3 wonderboymusic20 months ago

whoops - I added a patch at basically the exact same time

comment:4 scribu20 months ago

  • Description modified (diff)

scribu20 months ago

comment:5 scribu20 months ago

21734.2.diff resurrects global_terms_enabled() and adds TODO for where the code for installing the plugin should go.

comment:6 wonderboymusic19 months ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 3.5

Patch refreshed to accomodate plugin, which now here: http://plugins.svn.wordpress.org/global-terms/trunk/global-terms.php (first rev, needs love / testing)

Version 0, edited 19 months ago by wonderboymusic (next)

comment:7 follow-up: scribu19 months ago

Why is the change in get_blog_permalink() needed?

$link = set_url_scheme( get_permalink( $post_id ) , 'http' );

comment:8 in reply to: ↑ 7 SergeyBiryukov19 months ago

Replying to scribu:

Why is the change in get_blog_permalink() needed?

That was from ticket:19420:blog-perma-set-url-scheme.diff on #19420.

comment:9 nacin19 months ago

  • Keywords punt added

Not sure I have the stomach for this right now. It's fairly unobtrusive code that we've not needed to maintain or touch since we disabled global terms by default in 3.0.

comment:10 scribu19 months ago

  • Keywords punt removed
  • Milestone changed from 3.5 to Future Release

If it doesn't block #5809, I'm fine with it.

comment:11 kawauso16 months ago

  • Cc kawauso added

comment:12 wonderboymusic8 months ago

  • Keywords needs-refresh added; has-patch needs-testing removed
  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed

I don't think this matters right now

Note: See TracTickets for help on using tickets.