WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#21741 closed enhancement (fixed)

wp_script_is() and wp_style_is() should use 'enqueued' so it reads like a sentence

Reported by: nacin Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

wp_script_is( $handle, $list = 'queue' ) reads like "Is the script queue?" Another parameter for $list is 'registered', "Is the script registered?" Given that the function is wp_enqueue_script(), we should allow for $list = 'enqueued', as in "Is the script enqueued?" Same goes for wp_style_is().

Attachments (1)

21741.diff (3.6 KB) - added by obenland 3 years ago.

Download all attachments as: .zip

Change History (4)

@obenland3 years ago

comment:1 @obenland3 years ago

21741.diff:

  • Changes all 'queue' slugs to 'enqueued' in wp_*_is() functions
  • Matches PHPDoc for wp_*_is() functions
  • Adds indentation, simplification of return value and mapping from 'enqueued' to 'queue' in WP_Dependencies->query() method.

comment:3 @nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21672]:

Have wp_script_is() and wp_style_is() accept 'enqueued', as it reads better than 'queue' and is consistent with 'registered'. fixes #21741.

Note: See TracTickets for help on using tickets.