WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#21743 closed enhancement (fixed)

Twenty Twelve: add support for Status post format

Reported by: lancewillett Owned by: lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

As discussed in #wordpress-dev IRC team meeting today, task is to enable the Status post format.

Drew will provide styles.

Attachments (6)

21743.diff (2.6 KB) - added by drewstrojny 9 years ago.
21743.png (100.0 KB) - added by drewstrojny 9 years ago.
21743.2.diff (3.2 KB) - added by lancewillett 9 years ago.
Update RTL styles to match
huge-avatar.png (69.4 KB) - added by lancewillett 9 years ago.
80px-no-clear.png (39.8 KB) - added by drewstrojny 9 years ago.
80px-with-clear.png (40.0 KB) - added by drewstrojny 9 years ago.

Download all attachments as: .zip

Change History (23)

#1 @obenland
9 years ago

  • Cc konstantin@… added

#2 @lancewillett
9 years ago

In [21726]:

Twenty Twelve: add support for Status post format. See #21743.

#3 @lancewillett
9 years ago

  • Cc drewstrojny added
  • Status changed from new to assigned

Support is added, with a right-floated 48 pixel avatar.

Passing to Drew for a style review.

#4 @SergeyBiryukov
9 years ago

  • Type changed from defect (bug) to enhancement

#5 @lancewillett
9 years ago

I pinged Drew again today to review this for design integration, so I can close it.

@drewstrojny
9 years ago

@drewstrojny
9 years ago

#6 @drewstrojny
9 years ago

Added styles for Status post format (screenshot attached).

#7 @lancewillett
9 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner changed from drewstrojny to lancewillett
  • Status changed from assigned to accepted

@lancewillett
9 years ago

Update RTL styles to match

#8 follow-up: @lancewillett
9 years ago

@drewstrojny I think the "clear" class you added is unnecessary. Did you see any float clearing problems?

In my testing it works fine without it.

(I'd also prefer to keep it out of the markup if possible.)

#9 follow-up: @lancewillett
9 years ago

Also, I think we can use the_author() instead of echo get_the_author_meta( 'display_name' ) to output the Display Name: http://codex.wordpress.org/Function_Reference/the_author.

#10 in reply to: ↑ 8 ; follow-up: @drewstrojny
9 years ago

Replying to lancewillett:

@drewstrojny I think the "clear" class you added is unnecessary. Did you see any float clearing problems?

I added it to make the module itself a bit more bulletproof. If someone increases the size of the avatar and adds some extra meta it will still clear completely and look good. If the <header> isn't cleared the content could start wrapping up against it in that scenario.

Feel free to move the clear stuff to the stylesheet if you prefer it. I know you guys extracted the old clearing method we were using with Sass and replaced it with something else. I poked around a bit and found the clear class.

In summary, I think I'd prefer we keep it, but it doesn't have to be in the markup.

#11 in reply to: ↑ 9 @drewstrojny
9 years ago

Replying to lancewillett:

Also, I think we can use the_author() instead of echo get_the_author_meta( 'display_name' ) to output the Display Name: http://codex.wordpress.org/Function_Reference/the_author.

Good idea. I was initially toying with using the user's URL in that spot and forgot about the_author.

#12 in reply to: ↑ 10 ; follow-up: @lancewillett
9 years ago

Replying to drewstrojny:

Replying to lancewillett:

@drewstrojny I think the "clear" class you added is unnecessary. Did you see any float clearing problems?

I added it to make the module itself a bit more bulletproof. If someone increases the size of the avatar and adds some extra meta it will still clear completely and look good. If the <header> isn't cleared the content could start wrapping up against it in that scenario.

Gotcha, I tested out a huge gravatar image and the content below (paragraph) actually looks OK wrapped against it. And it's cleared below by .entry-meta element so the flow is reset before the element below.

#13 @lancewillett
9 years ago

In [21932]:

Twenty Twelve: update status post format styles and markup, props drewstrojny. See #21743.

#14 in reply to: ↑ 12 @drewstrojny
9 years ago

Gotcha, I tested out a huge gravatar image and the content below (paragraph) actually looks OK wrapped against it. And it's cleared below by .entry-meta element so the flow is reset before the element below.

I was testing it with a medium size image (say 80px) and some ugliness creeps in. I'll upload a couple screenshots.

#15 @lancewillett
9 years ago

OK, we can solve this pretty easily by adding clear: both; — that will force the paragraph element (first part of the real post content) to not wrap around the header element.

#16 @lancewillett
9 years ago

Looking more closely, I think I'll rework the markup in the template to match the pattern we use elsewhere, entry-header and entry-content separated out.

#17 @lancewillett
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [21933]:

Twenty Twelve: rework markup and styles for status post format after discussion with drewstrojny and testing for float clearing. Closes #21743.

Note: See TracTickets for help on using tickets.