Escape i18n attributes as late as possible

[mfields]

The following code is found in multiple places in both Twenty Ten and Twenty Eleven:

printf( esc_attr__( 'Permalink to %s', 'textdomain' ), the_title_attribute( 'echo=0' ) )

While the value of the_title_attribute() is escaped before it is returned in this example, this code could be reworked to demonstrate the best practice of escaping as late as possible:

echo esc_attr( sprintf( __( 'Permalink to %s', 'textdomain' ), the_title_attribute( 'echo=0' ) ) )

Twenty Twelve is currently using code similar to the second example.

[mfields]

Escape i18n attributes as late as possible in Twenty Ten and Twenty Eleven.

[lancewillett]

In [22197]:

Twenty Ten: escape i18n attributes as late as possible, fixes cases in loop.php -- props mfields. See #21756.

[lancewillett]

Ran into a small issue with the patch, for Twenty Eleven — there's an extra echo in content-gallery.php that throws an error.

[lancewillett]

Fixes extra echo in content-gallery.php

[lancewillett]

In [22199]:

Twenty Eleven: escape i18n attributes as late as possible, props mfields. See #21756.