WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #21760, comment 44


Ignore:
Timestamp:
07/05/2014 08:03:46 AM (6 years ago)
Author:
tollmanz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21760, comment 44

    initial v1  
    33A couple thoughts on the patch:
    44
    5 * Line 980 of **src/wp-includes/taxonomy.php** should use `$term->term_id` as the key, not the `$term` object.
     5* ~~Line 980 of **src/wp-includes/taxonomy.php** should use `$term->term_id` as the key, not the `$term` object.~~
    66* `$bucket` is not a term used in core (other than fleetingly in a few comments). I think for clarity and consistency, we should stick with the `$group` nomenclature.
    77* The keys for the term names will prove problematic. Whitespace is not allowed in Memcached keys. Additionally, these keys can only be a grand total of 250 characters in Memcached (and I'm assuming there are other limits in other object caches). These should be hashed or sanitized in someway before being used as keys.