Make WordPress Core

Opened 6 years ago

Closed 3 years ago

#21769 closed enhancement (wontfix)

Can we remove un-minified versions of all external libraries?

Reported by: ocean90 Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.5
Component: External Libraries Keywords:
Focuses: Cc:


With [21646] and [21648] we had removed the un-minified versions of Jcrop and jQuery Color.

A quick search through the plugin repo shows that there is only one plugin which includes the script directly:

Pie Register: http://plugins.trac.wordpress.org/browser/pie-register/trunk/pie-register.php#L1444

Should we be consistent and remove the un-minified versions of other external libraries too? These would be:

  • colorpicker.js
  • hoverIntent.js
  • jquery.imgareaselect.js
  • cropper.js (not used in core anymore and no minified version exists)
  • json2.js
  • tw-sack.js

Change History (7)

#2 @ocean90
6 years ago

  • Milestone changed from Awaiting Review to 3.5

#3 @helenyhou
6 years ago

  • Milestone changed from 3.5 to Future Release
  • Type changed from defect (bug) to enhancement

Need to think about benefits vs. breaking plugins. Punting per scrub today.

#4 @wonderboymusic
3 years ago

  • Milestone changed from Future Release to 4.2

We should answer JS questions like this in 4.2

#5 @ericlewis
3 years ago

I think we should do the opposite - include all unminified versions of scripts, and load them instead if the SCRIPT_DEBUG constant is true. This makes debugging through third-party scripts much easier. I suggest closing this, and follow-up on incorporating all unminified versions in #25244

#6 @Stagger Lee
3 years ago

I agree with @Eric. So many times i needed code from unminified files for troubleshooting.

#7 @ocean90
3 years ago

  • Keywords dev-feedback removed
  • Milestone 4.2 deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.