Scheduled pages/posts should not appear in custom menus

[Lorangeo]

When I add a scheduled page/post in a custom menu the page/post immediately appears in the front-end menu.

I think these scheduled pages/posts should only be visible in the front-end navigation when their scheduled time is reached (as it is the case with automatic menus). Otherwise the "Schedule" functionality makes no sense with custom menus, especially for pages.

Here is another forum post regarding this issue: ​http://wordpress.org/support/topic/custom-menu-support-for-scheduled-pagesposts

[ericlewis]

Could not replicate the bug on trunk with twentyeleven.

If no custom menu has been created, the default menu uses the function wp_page_menu, which via wp_list_pages get_pages queries only for pages that have a post status of 'publish', while any scheduled pages would have the post status of 'future.'

[Lorangeo]

The default menu (which is automatically generated) is OK. The problem is with custom menus.

It should be possible to create a custom menu, add some scheduled pages to it, and expect that these scheduled pages will only appear in the front-end menu when their scheduled time is reached.

Sorry if I'm not clear but my English is somewhat limited.

[jdcohan]

Related:

Private and Draft pages also appear (to all users, including non-logged-in) in a Primary Navigation menu which is based on a Custom Menu. My most recent confirmed test was with WordPress 3.4.2 and Twenty Ten 1.4.

Seems to me this is a defect. I'm just saying...

[Lorangeo]

jdcohan is right. Pages set as "Private" or "Draft" still appear in custom menus, even for users that are not logged in and that should not be aware of these contents.

From the ​WP codex:

Private content is published only for your eyes, or the eyes of only those with authorization permission levels to see private content. Normal users and visitors will not be aware of private content.

Based on this I would also consider it a defect that hopefully shouldn't be too difficult to fix.

[alexfurr]

hi - this still seems to be a problem i.e. scheduled pages should NOT appear in a custom menu.
Any movement on this? I would imagine its quite a simple fix :) (he says!)

kind regards,

Alex

[helen]

Related: #24975

[SergeyBiryukov]

Related: #22341

[dkotter]

Added a patch that makes sure any menu items that are of the type post_type (so posts, pages, CPTs) don't show on the front-end if they don't have the publish status. So this will remove scheduled items, draft items and private items from showing up.

I wasn't sure on the best place to put this, as there is a _is_valid_nav_menu_item function that I thought maybe extending to include this functionality might make sense, but ultimately I just created a similar function to handle this.

I have tested this and it seems to work great, but am open to any ideas if there's a better way to approach this or better place to put this.

[welcher]

This very similar to 33742. Can we confirm this wasn't fixed along with that?