Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#21777 closed enhancement (fixed)

Replace multiple wp_enqueue_script() calls in nav-menus.php with dependencies

Reported by: SergeyBiryukov Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch
Focuses: Cc:


Replying to nacin:

Looking at wp-admin/nav-menus.php, looks like a lot of those lines should be removed in favor of dependencies.

Attachments (1)

21777.patch (1.4 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (4)

#1 @SergeyBiryukov
3 years ago

Didn't include 'common', since it's already enqueued in admin.php:

#2 @nacin
3 years ago

  • Milestone changed from Awaiting Review to 3.5

Note that postbox.js has jquery-ui-sortable as a dependency, but I am leaving it in 21777.patch because sortable is also used on that screen for the nav menus, not just postboxes.

#3 @nacin
3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21696]:

Replace multiple wp_enqueue_script() calls in nav-menus.php with dependencies. props SergeyBiryukov. fixes #21777.

Note: See TracTickets for help on using tickets.