WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#21784 closed defect (bug) (wontfix)

Merge edit_form_advanced and edit_page_form hooks

Reported by: solarissmoke Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.4.1
Component: Editor Keywords: 2nd-opinion has-patch close
Focuses: Cc:

Description

In the era of custom post types, having to register one hook for pages (edit_page_form) and one for all other post types (edit_form_advanced) to add stuff to the post editor seems a bit weird. I think that these should be consolidated.

I guess the most backward-compatible way would be to deprecate both of these hooks and add one that fires for all post types, and passes the post type as an argument?

Attachments (1)

21784.diff (516 bytes) - added by solarissmoke 3 years ago.
Something like this

Download all attachments as: .zip

Change History (4)

@solarissmoke3 years ago

Something like this

comment:1 @solarissmoke3 years ago

  • Keywords has-patch added

comment:2 @solarissmoke2 years ago

  • Keywords close added

The introduction of the edit_form_after_editor (r22446) resolves the issue that I had, so unless anyone still feels that having a separate hook for pages is unnecessary, this can probably be closed.

comment:3 @nacin2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

There are a *lot* of places that fire different hooks for pages versus everything else. Not worth fixing this one without a systematic approach.

Note: See TracTickets for help on using tickets.