Twenty Twelve as default theme

[markoheijnen]

Since Twenty Twelve will be included in 3.5 lets also make it a default for the current users that installes a WordPress installation from trunk/nightly build.

[markoheijnen]

Added a patch to remove the reference of Twenty Eleven in the Welcome panel and adds a filter to be able the same from inside the theme.

[SergeyBiryukov]

21789.2.patch​ also updates default sidebars_widgets option (see [18643]).

Twenty Twelve only has 3 sidebars.

[nacin]

I don't think the beta tester plugin is currently installing or updating Twenty Twelve. We should make sure it can with these changes.

Also, Twenty Twelve is going to be 1.0 before 3.5, and available for 3.4 installs. We should make sure we do install it with 3.5 if it doesn't exist, but don't upgrade it if it does.

This might require our wp-content/bundled code to get a bit more flexible. cc dd32.

[nacin]

In [22050]:

Twenty Twelve 1.0, barring any last-minute tweaks. see #21789.

[nacin]

In [22054]:

Make Twenty Twelve the default theme for new installs. props markoheijnen, SergeyBiryukov. see #21789.

[dd32]

Also, Twenty Twelve is going to be 1.0 before 3.5, and available for 3.4 installs. We should make sure we do install it with 3.5 if it doesn't exist, but don't upgrade it if it does.

This should be the case already. We have a check for it if ( $wp_filesystem->is_dir($dest . $filename) ) continue; ​here.

I don't think the beta tester plugin is currently installing or updating Twenty Twelve. We should make sure it can with these changes.

Upgrading using the builtin upgrader will NOT be upgrading the bundled theme or plugins, thoughts: (for before beta 2)

1. Core should detect that either old, or new version is an non-stable release (nacin suggests existence of a dash in version number), and in the event of that, force overwrites of bundled items.
2. Add a filter around the skip, defaulting to the current existance checks, to allow for plugins (beta tester) to force overwrites - although point 1 would probably cover this.. there's no harm in adding the filter?

[dd32]

If we were to go for number 1 above, the scenario's i see are (and the current bevhaviour)

from	to	ideal behaviour	current behaviour
3.4	3.5-beta2	installs 2012	installs 2012
3.4 (with 2012)	3.5-beta1	overwrites 2012	skips 2012
3.5-beta2	3.5-beta3	overwrites 2012	skips 2012
3.5-RC3	3.5	overwrites 2012	skips 2012
3.4	3.5	installs 2012	installs 2012
3.4 (with 2012)	3.5	skips 2012	skips 2012

[dd32]

In attempting this I've run into #11639 again, and the simplest option is to just fix it.

I'm attaching a patch here which covers both this AND #11639 - without the #11639 component of the patch, the 3.4->3.5-beta1 branch in the above table would fail (but the others would work).

@nacin: What do you think, Fix #11639 or leave scenario 2 from the above table to "fail"? (while fixing scenario 3 and 4)

[dd32]

In [22226]:

When upgrading a site to/from a Beta, alpha, or non-stable release, overwrite any existing bundled themes & plugins with the version from the release zip. See #21789

[dd32]

In [22227]:

Replace the hard coded version and PHP/MySQL requirements in update-core.php by pulling in the new version.php file during installation. Fixes #22015 #11639. See #21789

[dd32]

Final logic table:

from	to	ideal behaviour	old behaviour	[22226] behaviour	[22227] behaviour
3.4	3.5-beta2	installs 2012	installs 2012	installs 2012	installs 2012
3.4 (with 2012)	3.5-beta1	overwrites 2012	skips 2012	skips 2012	overwrites 2012
3.5-beta2	3.5-beta3	overwrites 2012	skips 2012	overwrites 2012	overwrites 2012
3.5-RC3	3.5	overwrites 2012	skips 2012	overwrites 2012	overwrites 2012
3.4	3.5	installs 2012	installs 2012	installs 2012	installs 2012
3.4	3.5.1	installs 2012	installs 2012	installs 2012	installs 2012
3.4 (with 2012)	3.5	skips 2012	skips 2012	skips 2012	skips 2012
3.5 (with 2012)	3.5.1	skips 2012	skips 2012	skips 2012	skips 2012

In the case where it skips installing/updating it does NOT update the language files for the theme. Theme updates via the Theme Upgrader will continue to miss translations unless they're added to the .org theme zip.

I think that's all needed for the ticket.