WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#21796 closed enhancement (fixed)

Don't show paths in wp_upload_dir()

Reported by: nacin Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Upload Keywords:
Focuses: Cc:
PR Number:

Description

wp_upload_dir() unnecessarily shows the full path to an upload directory in case it can't create it. We shouldn't even bother showing the path at all — an error of "Error uploading file. Is the uploads directory writeable by the server?" should be sufficient.

Change History (5)

#1 @nacin
7 years ago

In [21757]:

A more generic message for wp_upload_dir(). see #21796, for 3.4.

#2 @nacin
7 years ago

For 3.5, I'm debating between [21757] and a generic "Error uploading file. Is the uploads directory writeable by the server?" [21757] was designed to not break the string.

#3 @SergeyBiryukov
7 years ago

I'd prefer [21757]. With a generic message, new users would have to guess where the uploads directory is.

#4 @SergeyBiryukov
7 years ago

  • Milestone changed from 3.4.2 to 3.5

#5 @ryan
7 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [22276]:

A more generic message for wp_upload_dir(). Props nacin. fixes #21796

Note: See TracTickets for help on using tickets.