WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

Last modified 5 years ago

#2180 closed defect (bug) (fixed)

Closed comments doesn't surround the output of comments_popup_link with a class

Reported by: Michael Owned by: rob1n
Milestone: 2.2 Priority: normal
Severity: normal Version: 2.0
Component: Template Keywords: has-patch commit
Focuses: Cc:

Description

When using comments_popup_link, the fourth parameter sets the class of the link around the comments. However, if the comments are closed on an entry, no class is set. It would perhaps be preferable if there was a 'before' and 'after' parameter set, so one could surround the comment with a span or something similar.

Attachments (1)

2180.diff (503 bytes) - added by rob1n 7 years ago.

Download all attachments as: .zip

Change History (6)

rob1n7 years ago

comment:1 rob1n7 years ago

  • Keywords has-patch 2nd-opinion added; comments "comments_popup_link" "template tag" removed
  • Milestone set to 2.2
  • Owner changed from anonymous to rob1n

Any thoughts? I'm impartial, really.

comment:2 Nazgul7 years ago

From a user point of view I'm impartial as well.

From a programmers point of view I'm in favor of this patch. I have the option to pass a css class to the function, which then isn't used consistently. That seems counter-intuitive.

comment:3 rob1n7 years ago

I agree.

comment:4 rob1n7 years ago

  • Keywords commit added; 2nd-opinion removed

comment:5 rob1n7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5165]) Add CSS class in if it's not empty when there's no comments. fixes #2180

Note: See TracTickets for help on using tickets.