WordPress.org

Make WordPress Core

Opened 23 months ago

Closed 5 months ago

#21826 closed enhancement (wontfix)

There should be more filters when displaying a theme in the list table

Reported by: ethitter Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.4
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

In WP_Themes_List_Table::display_rows(), there is a filter for the theme actions, but no filters for the theme information itself: screenshot, title, author, version, and description. Why not fix that?

The attached patch introduces theme_list_* filters within the display_rows() method. Suppressing one of the pieces of information is simply a matter of returning an empty value through the filter.

Attachments (2)

21826.patch (2.4 KB) - added by ethitter 23 months ago.
21826.2.patch (2.6 KB) - added by ethitter 23 months ago.
Converts to a single filter and an array

Download all attachments as: .zip

Change History (6)

ethitter23 months ago

comment:1 follow-up: scribu23 months ago

  • Component changed from Themes to Administration

I think a single filter for all the theme's attributes would make more sense. And WP_Theme might actually already have it.

comment:2 in reply to: ↑ 1 ethitter23 months ago

Replying to scribu:

I think a single filter for all the theme's attributes would make more sense. And WP_Theme might actually already have it.

A single filter would certainly be more efficient and seems fine. I'll work up a new patch.

I'm not opposed to adding filters in WP_Theme (if they don't already exist; I couldn't find any), but I'd rather those be a separate set. Discerning context from filters in WP_Theme will be challenging, and I think many uses of the filters will be context-specific rather than universal.

ethitter23 months ago

Converts to a single filter and an array

comment:3 SergeyBiryukov22 months ago

  • Version changed from trunk to 3.4

comment:4 nacin5 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Due to 3.8.

Note: See TracTickets for help on using tickets.