ERR_NOTICE in wp_mime_type_icon

[mark8barnes]

There's a bug in wp_mime_type_icon (wp-includes/post.php) which gives an ERR_NOTICE when a non-numeric mime-type is retrieved from the cache. The second line of the following code reproduces the error:

$icon1 = wp_mime_type_icon ('application/ogg'); // No cache, so no error
$icon2 = wp_mime_type_icon ('application/ogg'); // Uses cache, so gives error

The full message is Notice: Undefined variable: post_id in D:\web\htdocs\wordpress\wp-includes\post.php on line 4127

The problem is obvious from the code and easy to fix. The attached patch does that.

[ocean90]

#21835

[nacin]

Hi mark8barnes, neither koopersmith nor I saw this ticket before it went in. I'll make sure you're listed on the 3.5 credits page as if you received "props" for this patch. Cheers!

[mark8barnes]

Thanks, nacin.

[nacin]

#21614 was marked as a duplicate.