WordPress.org

Make WordPress Core

#21836 closed task (blessed) (fixed)

Handle non-image attachments in new media modal

Reported by: koopersmith Owned by: koopersmith
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords:
Focuses: Cc:

Description

Currently the new media modal assumes all attachments are images. Since not all attachments are images, this is probably not a good thing to do.

We should create a way for developers to seamlessly deal with non-image attachments.

Also, if any bugs along these lines crop up, please note them here.

Change History (5)

comment:1 koopersmith20 months ago

In [21784]:

Use icons for non-image attachments in the new media modal. see #21836, #21390, #21808.

comment:2 koopersmith20 months ago

Leaving this ticket open until we have something to handle non-image attachments at the API level.

comment:3 koopersmith19 months ago

In [22159]:

Show filenames for non-image attachments in the new media modal.

Also passes all attachment model attributes to the attachment view template by default (instead of selecting specific values).

see #21390, #21836.

comment:4 koopersmith19 months ago

In [22170]:

Correctly insert non-image attachments as links.

  • Adds wp.media.string.link( attachment ) for printing attachment links.
  • Adds the link attribute to Attachment models that corresponds to the link to the attachment post.

see #21390, #21836.

comment:5 koopersmith17 months ago

  • Owner set to koopersmith
  • Resolution set to fixed
  • Status changed from new to closed

In 22671:

Media: Only show the alignment setting when viewing an image. fixes #21836, see #21390.

Note: See TracTickets for help on using tickets.