WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 7 years ago

Last modified 6 years ago

#21845 closed defect (bug) (fixed)

Losing comment reply by accidentally clicking on another comment

Reported by: icc97 Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.4
Component: Comments Keywords: has-patch commit
Focuses: ui, administration Cc:

Description

This is a usability bug.

When replying to a comment in the Edit Comments (wp-admin/edit-comments.php) page, double-clicking on another comment will open that comment for editing and wipe away the reply you were writing.

If you want to highlight a word to copy from the comment that you are replying to this can be done by double-clicking the word. So completely by accident your reply is wiped out. This occurred on wordpress.com so I'm guessing their using the latest 3.4.2 version.

Attachments (3)

21845.diff (850 bytes) - added by pareshradadiya 7 years ago.
Proposed fix
21845.2.diff (1.5 KB) - added by pareshradadiya 7 years ago.
l10n the string added
21845.3.patch (1.3 KB) - added by chriscct7 7 years ago.
Fixes fatal error and corrects formatting

Download all attachments as: .zip

Change History (14)

#1 @MikeHansenMe
9 years ago

  • Keywords ux-feedback added

I am not sure I would consider this a bug but lets get some feedback from UX.

#2 @chriscct7
7 years ago

  • Focuses ui administration added
  • Keywords needs-patch added; ux-feedback removed

WordPress really should use some JS to detect a comment change and do a "are you sure you want to start quick editing a new comment? You will lose your changes to the comment you are currently editing" or something along those lines. This is a relatively minor ux issue though since you would not expect many people to double click on a different comment while editing one.

@pareshradadiya
7 years ago

Proposed fix

#3 follow-up: @pareshradadiya
7 years ago

  • Keywords has-patch added; needs-patch removed

#4 in reply to: ↑ 3 @chriscct7
7 years ago

  • Keywords needs-refresh added
  • Version changed from 3.4.2 to 3.4

Replying to pareshradadiya:

Can you l10n the string you've got in your patch?

@pareshradadiya
7 years ago

l10n the string added

#5 @pareshradadiya
7 years ago

  • Keywords needs-refresh removed

#6 @chriscct7
7 years ago

  • Owner set to chriscct7
  • Status changed from new to reviewing

Thanks! I'll review it today

@chriscct7
7 years ago

Fixes fatal error and corrects formatting

#7 @chriscct7
7 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Status changed from reviewing to accepted

Fixed a fatal error (space in the script loader l10n changes).

This looks good. Tagging for 4.3

Thanks @icc97 for the report and @pareshradadiya for your work on this :+1:

#8 @chriscct7
7 years ago

  • Keywords commit added

#9 @obenland
7 years ago

  • Owner changed from chriscct7 to obenland

#10 @obenland
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 32857:

Check that current changes can be lost before editing another comment.

When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.

Props pareshradadiya, chriscct7.
Fixes #21845.

#11 @SergeyBiryukov
6 years ago

#11328 was marked as a duplicate.

Note: See TracTickets for help on using tickets.