WordPress.org

Make WordPress Core

#21847 closed defect (bug) (fixed)

Align the custom fields metabox

Reported by: ocean90 Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description

See screenshots.

Attachments (10)

21847.patch (2.2 KB) - added by ocean90 20 months ago.
before.png (23.3 KB) - added by ocean90 20 months ago.
after.png (22.9 KB) - added by ocean90 20 months ago.
21847.2.patch (2.8 KB) - added by SergeyBiryukov 20 months ago.
21847.after.2.png (13.7 KB) - added by SergeyBiryukov 20 months ago.
after.body.png (40.6 KB) - added by ocean90 19 months ago.
after.side.png (36.7 KB) - added by ocean90 19 months ago.
21847.3.patch (3.7 KB) - added by ocean90 19 months ago.
21847.4.patch (4.4 KB) - added by SergeyBiryukov 19 months ago.
21847.after.4.png (43.9 KB) - added by SergeyBiryukov 19 months ago.

Download all attachments as: .zip

Change History (19)

ocean9020 months ago

ocean9020 months ago

ocean9020 months ago

comment:1 follow-up: scribu20 months ago

It looks aligned to me (Firefox 15).

comment:2 in reply to: ↑ 1 ocean9020 months ago

Replying to scribu:

It looks aligned to me (Firefox 15).

Hmm. Not for me.

Opera 12.02: http://cl.ly/JL5x

Firefox 14/15: http://cl.ly/JKm6

comment:3 scribu20 months ago

Yeah, if I use Firebug's rulers, I can see a few pixels difference too.

SergeyBiryukov20 months ago

comment:4 SergeyBiryukov20 months ago

Tested the patch in Chrome 21 and IE 7/8 as well, looks good.

'small' class should be appended, not prepended (#21852).

21847.2.patch also properly aligns "Enter new" link in Opera, "Add Custom Field" button in all browsers (attachment:21847.after.2.png), and removes a redundant line (#21833).

comment:5 SergeyBiryukov19 months ago

  • Component changed from Administration to UI

ocean9019 months ago

ocean9019 months ago

ocean9019 months ago

comment:6 ocean9019 months ago

Patch refreshed. Metabox is now optimized for #side-sortables too.

comment:7 SergeyBiryukov19 months ago

More tweaks and cleanup in 21847.4.patch. Screenshot: 21847.after.4.png.

A separate section for RTL is no longer needed, replaced with existing comment:
http://core.trac.wordpress.org/browser/tags/3.4.2/wp-admin/css/wp-admin-rtl.dev.css#L1274

Tested in Firefox 15, Chrome 21, IE 7, IE 8, Opera 12.

SergeyBiryukov19 months ago

comment:8 ocean9019 months ago

  • Keywords commit added

comment:9 nacin19 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21955]:

Better alignment in the ustom fields metabox. props SergeyBiryukov, ocean90, fixes #21847.

Note: See TracTickets for help on using tickets.