WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 29 hours ago

#21848 reviewing defect (bug)

A single space in the image caption breaks alignment

Reported by: luffer Owned by: wonderboymusic
Milestone: 4.2 Priority: low
Severity: trivial Version: 3.4.2
Component: Media Keywords: has-patch
Focuses: Cc:

Description

If you add just a single space in the caption field of an image using the media uploader, it ignores any alignment settings.

The expected behaviour would mean that regardless of what is entered into the caption box, the image alignment should be honoured.

Attachments (1)

21848.diff (1.1 KB) - added by wonderboymusic 3 weeks ago.

Download all attachments as: .zip

Change History (8)

comment:2 @ericlewis10 months ago

  • Severity changed from normal to trivial

@luffer thanks for the bug report! I can reproduce, but this is trivial.

Maybe we should be trim()ing captions on change in the media modal? Are there use cases where folks want untrimmed captions?

comment:3 @wonderboymusic4 weeks ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.2

@wonderboymusic3 weeks ago

comment:4 @wonderboymusic3 weeks ago

21848.diff fixes part of this.

comment:5 @samuelsidler4 days ago

  • Priority changed from normal to low

comment:6 @slackbot29 hours ago

This ticket was mentioned in Slack in #core by drew. View the logs.

comment:7 @DrewAPicture29 hours ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to wonderboymusic
  • Status changed from new to reviewing

21848.diff still applies. I could get behind even a partial fix here. @wonderboymusic: can you please commit what you've got so far if you think that's going to work, and either punt the ticket or make a recommendation on fixing what's left?

Note: See TracTickets for help on using tickets.