WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#21850 closed defect (bug) (fixed)

Press This focus/active style broken

Reported by: johnbillion Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description

Most likely due to changes made as part of #21598, the Press This button has lost its background style when being dragged.

http://i.imgur.com/uaIgd.png

Attachments (3)

21850.patch (547 bytes) - added by SergeyBiryukov 9 years ago.
21850.2.patch (382 bytes) - added by ocean90 9 years ago.
21850.2b.patch (214.9 KB) - added by davidcruz 9 years ago.

Download all attachments as: .zip

Change History (13)

#1 @SergeyBiryukov
9 years ago

  • Milestone changed from Awaiting Review to 3.5

#2 @SergeyBiryukov
9 years ago

  • Component changed from Administration to UI

#3 @SergeyBiryukov
9 years ago

  • Keywords has-patch added

#4 @helenyhou
9 years ago

  • Keywords commit added

Tested, looks good.

#5 @nacin
9 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21832]:

Fix Press This bookmarklet focus and active styles. props SergeyBiryukov, fixes #21850.

@ocean90
9 years ago

#6 follow-up: @ocean90
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Active status is still broken. 21850.2.patch fixes it.

@davidcruz
9 years ago

#7 in reply to: ↑ 6 ; follow-up: @davidcruz
9 years ago

Replying to ocean90:

Active status is still broken. 21850.2.patch fixes it.

I tested your patch in a trunk deploy but it didn't fix the issue because you forgot to also include the fix in the minified CSS file.

I attached an expanded version of your patch (21850.2b.patch) to apply the change to the minified file.

#8 in reply to: ↑ 7 ; follow-up: @SergeyBiryukov
9 years ago

Replying to davidcruz:

I tested your patch in a trunk deploy but it didn't fix the issue because you forgot to also include the fix in the minified CSS file.

There's no need to patch minified files, a post-commit bot takes care of it.

To test CSS or JS patches, you should add SCRIPT_DEBUG constant to your wp-config.php file:
http://codex.wordpress.org/Debugging_in_WordPress#SCRIPT_DEBUG

Last edited 9 years ago by SergeyBiryukov (previous) (diff)

#9 in reply to: ↑ 8 @davidcruz
9 years ago

Oh OK, sorry =(

I asked some folks at WordCamp to see if there was some building procedure to minify but seems nobody knew about post-commit hook.
Thank for info.

Replying to SergeyBiryukov:

Replying to davidcruz:

I tested your patch in a trunk deploy but it didn't fix the issue because you forgot to also include the fix in the minified CSS file.

There's no need to patch minified files, a post-commit bot takes care of it.

To test CSS or JS patches, you should add SCRIPT_DEBUG constant to your wp-config.php file:
http://codex.wordpress.org/Debugging_in_WordPress#SCRIPT_DEBUG

Last edited 9 years ago by SergeyBiryukov (previous) (diff)

#10 @nacin
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [22165]:

Fix the Press This bookmarklet's active style. props ocean90, fixes #21850.

Note: See TracTickets for help on using tickets.