Opened 14 years ago
Closed 14 years ago
#21850 closed defect (bug) (fixed)
Press This focus/active style broken
| Reported by: | johnbillion | Owned by: | nacin |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | UI | Version: | 3.5 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
Most likely due to changes made as part of #21598, the Press This button has lost its background style when being dragged.
Attachments (3)
Change History (13)
#6
follow-up:
↓ 7
@
14 years ago
- Resolution fixed
- Status closed → reopened
Active status is still broken. 21850.2.patch fixes it.
#7
in reply to: ↑ 6
;
follow-up:
↓ 8
@
14 years ago
Replying to ocean90:
Active status is still broken. 21850.2.patch fixes it.
I tested your patch in a trunk deploy but it didn't fix the issue because you forgot to also include the fix in the minified CSS file.
I attached an expanded version of your patch (21850.2b.patch) to apply the change to the minified file.
#8
in reply to: ↑ 7
;
follow-up:
↓ 9
@
14 years ago
Replying to davidcruz:
I tested your patch in a trunk deploy but it didn't fix the issue because you forgot to also include the fix in the minified CSS file.
There's need to patch minified files, a post-commit bot takes care of it.
To test CSS or JS patches, you should add SCRIPT_DEBUG constant to your wp-config.php file:
http://codex.wordpress.org/Debugging_in_WordPress#SCRIPT_DEBUG
#9
in reply to: ↑ 8
@
14 years ago
Oh OK, sorry =(
I asked some folks at WordCamp to see if there was some building procedure to minify but seems nobody knew about post-commit hook.
Thank for info.
Replying to SergeyBiryukov:
Replying to davidcruz:
I tested your patch in a trunk deploy but it didn't fix the issue because you forgot to also include the fix in the minified CSS file.
There's no need to patch minified files, a post-commit bot takes care of it.
To test CSS or JS patches, you should add
SCRIPT_DEBUGconstant to yourwp-config.phpfile:
http://codex.wordpress.org/Debugging_in_WordPress#SCRIPT_DEBUG
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)

Tested, looks good.