WordPress.org

Make WordPress Core

Opened 19 months ago

Closed 18 months ago

Last modified 10 months ago

#21863 closed defect (bug) (fixed)

box-sizing breaks some admin-bar elements

Reported by: betzster Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: minor Version: 3.5
Component: Toolbar Keywords: has-patch commit
Focuses: Cc:

Description

If I do something like * { box-sizing: border-box; } in my theme, it breaks some of the admin-bar elements — the stats item in particular is affected. This is easily fixed by forcing everything in #wpadminbar to box-sizing: content-box.

Attachments (3)

21863.patch (446 bytes) - added by betzster 19 months ago.
Adds box-sizing: content-box to everything in #wpadminbar
21863.2.patch (451 bytes) - added by SergeyBiryukov 19 months ago.
With proper formatting
Screen Shot 2013-06-20 at 10.33.36 AM.png (60.5 KB) - added by ericlewis 10 months ago.
Show box-sizing applied to TinyMCE buttons

Download all attachments as: .zip

Change History (12)

betzster19 months ago

Adds box-sizing: content-box to everything in #wpadminbar

comment:1 nacin19 months ago

  • Milestone changed from Awaiting Review to 3.5

SergeyBiryukov19 months ago

With proper formatting

comment:2 SergeyBiryukov19 months ago

See CSS Coding Standards for the preferred formatting.

comment:3 SergeyBiryukov19 months ago

  • Component changed from Administration to Toolbar

comment:4 helenyhou18 months ago

  • Keywords commit added

[21863.2.patch] seems to work for me, didn't notice anything broken without it in core items but definitely see the inconsistencies and potential for breakage.

comment:5 nacin18 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [22280]:

Reset box-sizing to toolbar CSS to avoid conflicts with themes. props betzster, fixes #21863.

comment:6 follow-up: ericlewis10 months ago

[22280] mucks up styling a bit on WP Editor instances, at least in twentythirteen.

The TinyMCE buttons get the box-sizing declaration applied, which shrinks the container for the buttons a bit. I'll attach a screenshot.

ericlewis10 months ago

Show box-sizing applied to TinyMCE buttons

comment:7 in reply to: ↑ 6 ; follow-up: betzster10 months ago

Replying to ericlewis:

[22280] mucks up styling a bit on WP Editor instances, at least in twentythirteen.

The TinyMCE buttons get the box-sizing declaration applied, which shrinks the container for the buttons a bit. I'll attach a screenshot.

The changes here apply to #wpadminbar * (the admin bar), not the editor.

comment:8 in reply to: ↑ 7 ; follow-up: ericlewis10 months ago

Replying to betzster:

The changes here apply to #wpadminbar * (the admin bar), not the editor.

Ah whoops, my bad. I guess this is a bug in twentythirteen then.

comment:9 in reply to: ↑ 8 SergeyBiryukov10 months ago

Replying to ericlewis:

Ah whoops, my bad. I guess this is a bug in twentythirteen then.

Related: ticket:24450:4

Note: See TracTickets for help on using tickets.