wp_list_categories show_option_all does not work for custom taxonomy

[arkinex]

I am using wp_list_categories on a custom post type page to list the taxonomy values (categories). However if I include an All link it links by default to /blog/ and not /taxonomy/.

[sirzooro]

#21881 was marked as a duplicate.

[sirzooro]

#21882 was marked as a duplicate.

[SergeyBiryukov]

Related: #18610

[wonderboymusic]

A patch will move this along. Thanks for the report, arkinex.

[landakram]

arkinex, thanks for the bug report :)

It looks like there's no general category page (i.e. /category by default) that would display all posts by all categories.

Since $posts_page is the right path for displaying all posts, isn't linking to the posts page the desired behavior here?

[stevegrunwell]

Patch added, but it could use some unit tests (along with the rest of wp_list_categories(). If the post_type query var is populated, the returned URL will come from get_post_type_archive_link() instead of get_permalink( get_option( 'page_for_posts' ) ) or home_url( '/' ).

First patch, any and all feedback welcome :).

[stevegrunwell]

As get_query_var() can return arrays, only use get_post_type_archive_link() will receive a string

[stevegrunwell]

Talking it through with Nacin, we realized that changing the "all" link based on context was the wrong behavior. Instead, if a post type is only used for one, non-built-in taxonomy, link to the archive for that post type (if it exists).

[boonebgorges]

In 31301:

Add unit tests for 'show_option_all' behavior of wp_list_categories().

See #21881.

[boonebgorges]

stevegrunwell - Thanks for working on this. The approach in the patch looks mostly good to me. The only change I'll suggest is that when a taxonomy is associated with more than one post type, we should still try to do something intelligent with it, even if it's just grabbing the first member of object_type that has_archive.

I wrote a few unit tests for the existing behavior in [31301]. Perhaps you could use them as a template for additional tests that describe the current bug. Off the top of my head, the cases seem like this: (a) more than one object_type and the first one has_archive; (b) more than one object_type and the first one does *not* has_archive; (c) none of the object_types has_archive.

[hrishiv90]

Updated patch as suggested by @boonebgorges

[hrishiv90]

Hi,

As per @boonebgorges suggestion, I have updated the patch to handle all types of conditions as to check if more than one object_type and first one either has_archive enabled or disabled with continuing the check on further object types (post_type).

I used array_shift instead of normal indexing ($object_type[$i]) in the loop as the array obtained from taxonomy->object_type may start from any number as index instead of fixed number 0 depending on the post_types taxonomy has been registered with.

[boonebgorges]

hrishiv90 - Thanks for the patch. This is getting close. 21881.5.patch​ includes a unit test for the new behavior, and simplifies the logic of 4.patch a little (also accounting for the possibility that an object_type might not be a valid post type).

[boonebgorges]

In 32292:

In wp_list_categories(), 'All' link should point to post type archive if taxonomy is not registered for 'post' or 'page'.

Instead, we point to the post type archive of the first registered
object_type that supports archives.

Props stevegrunwell, hrishiv90, boonebgorges.
Fixes #21881.