WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#21886 closed enhancement (fixed)

PHPDocs for options_reading_blog_charset()

Reported by: SergeyBiryukov Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: trivial Version: 3.5
Component: Inline Docs Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Background: #21507

Attachments (4)

21886.patch (1.7 KB) - added by SergeyBiryukov 7 years ago.
21886.2.patch (1.7 KB) - added by SergeyBiryukov 7 years ago.
Refreshed after [21856]
21886.3.patch (1.5 KB) - added by SergeyBiryukov 7 years ago.
21886.4.patch (1.2 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (9)

@SergeyBiryukov
7 years ago

Refreshed after [21856]

#1 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21872]:

Docs for options_reading_blog_charset(). props SergeyBiryukov, fixes #21886.

#2 @SergeyBiryukov
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

add_js() was originally added in 3.1: [15946] (for #15205). Was the change to 3.5 in the commit intentional?

21886.3.patch adds @since for other *_add_js() functions.

Not sure if @package and @subpackage are relevant for those functions. The patch removes them for consistency with [21872].

#3 @nacin
7 years ago

@package and @subpackage are rarely relevant for functions at all. Since we renamed add_js(), I changed the @since to when it was actually introduced. Normally we'd also include some info about when it was originally introduced (before rename), but this is just a formality, as these are internal functions anyway.

#4 @SergeyBiryukov
7 years ago

I see. 21886.4.patch adds @since 3.5.0 for other renamed functions.

#5 @nacin
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21994]:

@since for some internal functions. props SergeyBiryukov, fixes #21886.

Note: See TracTickets for help on using tickets.