#21890 closed defect (bug) (fixed)
Customizer spinner breaks button alignment with longer strings
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.8 | Priority: | normal |
Severity: | normal | Version: | 3.4 |
Component: | Customize | Keywords: | has-patch |
Focuses: | ui | Cc: |
Description
See the screenshot.
Attachments (9)
Change History (28)
#3
@
12 years ago
21890.diff is a quick hack. There is very likely a better way to handle this, but nothing is coming to mind.
#7
follow-up:
↓ 8
@
12 years ago
One drawback of this solution to consider is that if the customizer ends up locked up during a save at any point for any reason (ajax request failures are not uncommon), there's no cancel button to click anymore to back out to the admin (other than hitting the back button of course, but the Cancel button is obviously more "trust-worthy" to a user).
#8
in reply to:
↑ 7
@
12 years ago
- Keywords commit removed
Replying to bpetty:
Agreed. Current patch just feels hacky all around - magic numbers and all that. Any other ideas out there?
#10
@
12 years ago
Could we decrease the left and right padding on those buttons by 2px?
That would help with the issue as well: 21890.after.png.
If that's not feasible as a default appearance, 21890.2.alt.diff does the same only for ru_RU. The rtl
class is not necessary for ru_RU, but might be useful for other locales (we already use a similar pattern in admin-header.php
and press-this.php
).
#11
@
12 years ago
Yeah, it does at least need something there to help, and that could do for now.
We could then take the time to consider some new behavior like possibly switching out the Save button with a Cancel button while it's working or something to that effect.
#13
@
12 years ago
- Keywords needs-patch added; has-patch removed
- Milestone changed from 3.5 to Future Release
#14
@
11 years ago
- Keywords ui-focus has-patch added; needs-patch removed
- Milestone changed from Future Release to 3.8
The new admin with Open Sans reintroduced this issue due to increased font width. See 21890.2.png.
21890.3.diff adjusts some padding for proper alignment: 21890.3.after.png.
#15
@
11 years ago
21890.4.diff includes the same for .locale-de-de
, where we have the same issue.
#16
@
11 years ago
@SergeyBiryukov
Seems like we have to change the style when the media query kicks in too, see http://cl.ly/SkPo.
#17
@
11 years ago
- Owner set to iammattthomas
- Resolution set to fixed
- Status changed from new to closed
In 26624:
Unfortunately, I can't come up with a shorter translation.
Perhaps "Cancel" button can be hidden when the spinner is active?