WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#21893 closed enhancement (fixed)

Code formatting and Inline Doc improvements in wp-includes/general-template.php

Reported by: c3mdigital Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: normal Version: 1.5
Component: Inline Docs Keywords: has-patch commit
Focuses: Cc:

Description

Patch is a coding standards cleanup (whitespace) for wp-includes/general-template.php. Also adds some missing @return statements in PHPDocs.

Attachments (3)

21893.patch (23.6 KB) - added by c3mdigital 8 years ago.
21893.2.patch (2.9 KB) - added by c3mdigital 8 years ago.
PHPDoc fixes only
21893.3.patch (3.7 KB) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (9)

@c3mdigital
8 years ago

#1 @helenyhou
8 years ago

  • Component changed from Formatting to Inline Docs

#2 follow-up: @SergeyBiryukov
8 years ago

http://wpdevel.wordpress.com/2011/03/23/code-refactoring/

There was a number of code cleanup tickets like #17997, and the consensus was that coding style fixes should be a result of more substantial changes than just improving readability.

Let's focus on PHPDocs here.

@c3mdigital
8 years ago

PHPDoc fixes only

#3 in reply to: ↑ 2 @c3mdigital
8 years ago

Replying to SergeyBiryukov:

http://wpdevel.wordpress.com/2011/03/23/code-refactoring/

There was a number of code cleanup tickets like #17997, and the consensus was that coding style fixes should be a result of more substantial changes than just improving readability.

Let's focus on PHPDocs here.

Thanks for the link. Makes a lot of sense. I updated the patch focusing only on the PHPDocs.

#5 @nacin
8 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.5

#6 @ryan
8 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [21926]:

phpdoc cleanups for general-template.php. Props c3mdigital, SergeyBiryukov. fixes #21893

Note: See TracTickets for help on using tickets.