WordPress.org

Make WordPress Core

Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#21909 closed defect (bug) (fixed)

Twenty Twelve: rename home page template to front-page

Reported by: lancewillett Owned by:
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Based on feedback from Nacin, changing the homepage template name to "Front Page Template" and the file to front-page.php will be more semantic and better for user experience. It also matches how core names the static front page option.

Attachments (2)

21909.diff (11.6 KB) - added by lancewillett 19 months ago.
21909.2.diff (13.4 KB) - added by lancewillett 19 months ago.

Download all attachments as: .zip

Change History (9)

lancewillett19 months ago

lancewillett19 months ago

comment:1 lancewillett19 months ago

Patch renames everything related to "home" to "front-page" instead, including body classes, function calls, and file names.

comment:2 lancewillett19 months ago

Anyone using Twenty Twelve in its beta mode via core trunk will need to resave any page that uses the front-page template, due to the template name change. The _wp_page_template post meta value should go from page-templates/home.php to page-templates/front-page.php for those pages.

Child theme authors should check their CSS as the following selector values are changing:

  1. s/template-home/template-front-page/
  2. s/home-widgets/front-widgets/

For WP.com I'll add a filter to the theme version there to update all the post meta values on each site on the fly, so nothing breaks in terms of page templates. I'll also fix the Custom CSS cases on WP.com by hand for the new CSS selectors -- after an audit I only found a few, maybe 5-6 sites that would be affected.

comment:3 lancewillett19 months ago

In [21886]:

Twenty Twelve: rename homepage template to front-page; including s/home/front-page/ in many places -- see notes in ticket. See #21909.

comment:4 lancewillett19 months ago

In [21893]:

Twenty Twelve: fix typo in stylesheet description, props nacin. See #21909.

comment:5 lancewillett19 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Code is now pushed out to WordPress.com with the additional filter to fix the template path; I also fixed 6 cases of Custom CSS selector changes.

comment:6 ocean9019 months ago

#21939 was marked as a duplicate.

comment:7 lancewillett19 months ago

A bit of IRC logs for good measure, our future selves will thank us.

First discussion, Aug 01 2012:
https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2012-08-01&sort=asc#m430809

Subsequent renaming discussion, Aug 28 2012:
https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2012-08-28&sort=asc#m445764

Note: See TracTickets for help on using tickets.