WordPress.org

Make WordPress Core

Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#21926 closed defect (bug) (fixed)

Margin Weirdness in Twenty Twelve with text, photos

Reported by: johnbierly Owned by: lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.4.2
Component: Bundled Theme Keywords: needs-patch
Focuses: Cc:

Description

Hi! The 9/18/2012 nightly build still has a weird thing in the Twenty Twelve theme. Unlike version 0.6 from GitHub, 0.9 doesn't display the left border on left-aligned photos, and the right side edge of text sometimes gets cut off on mobile view. Thank you!

Attachments (1)

missingleftborder.png (80.5 KB) - added by johnbierly 19 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 nacin19 months ago

  • Component changed from Themes to Bundled Theme
  • Milestone changed from Awaiting Review to 3.5

comment:2 johnbierly19 months ago

I attached a photo of the phenomenon. The alignment chosen when the photo was posted was "None." The borders are just fine on the 0.6 GitHub version of the theme.

comment:3 lancewillett19 months ago

  • Keywords needs-patch added

Thanks for the report.

This is related to #21740 — where we reviewed the overflow rules, as well as #21381 where the clearing float methods were simplified.

In the case of images aligned exactly to the left edge of their container, the shadow is indeed cut off since it requires 4 pixels of space.

comment:4 lancewillett19 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21918]:

Twenty Twelve: remove overflow rule from wrapper element to allow image styles to spill out into margins. Fixes #21926. See also #21381.

comment:5 lancewillett19 months ago

See also #21940 for related issue with Jetpack Image Widget — overflow is too aggressive.

Note: See TracTickets for help on using tickets.