Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 4 years ago

#21932 closed defect (bug) (fixed)

Twenty Twelve: Missing style rules for html elements that can be added in the text widget.

Reported by: iamtakashi's profile iamtakashi Owned by: lancewillett's profile lancewillett
Milestone: 3.5 Priority: low
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:


Since Twenty Twelve limits the styles for many html elements specifically inside .entry-content and .comment-content, (See Line 662 - 864 in style.css) those that can be inside a text widget are left unstyled.

As users are able to add html elements in a text widget, those should be styled accordingly as well.

Attachments (3)

widget_test_tags.txt (772 bytes) - added by DrewAPicture 12 years ago.
Test tags
21932.diff (669 bytes) - added by DrewAPicture 12 years ago.
ul, li and p
21932.2.diff (647 bytes) - added by lancewillett 12 years ago.

Download all attachments as: .zip

Change History (10)

#1 @lancewillett
12 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.5
  • Priority changed from normal to low

Thanks for the ticket, Takashi. I'm going to mark as minor since it's not a blocker for 1.0 going to Extend, in my opinion. But, it should be addressed soon.

#2 @lancewillett
12 years ago

#21965 was marked as a duplicate.

12 years ago

Test tags

#3 @lancewillett
12 years ago

I vote on only styling simple things, like paragraph elements and unordered lists. (Not headings and all other possible HTML input.)

12 years ago

ul, li and p

#4 @DrewAPicture
12 years ago

  • Cc xoodrew@… added
  • Keywords has-patch added; needs-patch removed

#5 @lancewillett
12 years ago

Thanks for the patch and screenshots. After testing, I think we should apply the p styles to .widget and the list and list item styles only to .textwidget.

#6 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21990]:

Twenty Twelve: style basic HTML elements in text widgets, props DrewAPicture. Fixes #21932.

This ticket was mentioned in Slack in #core-editor by johnstonphilip. View the logs.

4 years ago

Note: See TracTickets for help on using tickets.