WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 17 months ago

#21934 closed enhancement (worksforme)

Title field on Insert/edit link form shouldn't allow autosuggest

Reported by: goldenapples Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.4.2
Component: Editor Keywords: ux-feedback has-patch needs-refresh
Focuses: administration Cc:
PR Number:

Description

When entering a link through the "Insert/edit link" thickbox form, Firefox displays autosuggest dropdowns for both the URL field and the title field.

This would be helpful, except that the javascript keyboard handlers bound on keydown/keyup prevent the browser UI from being accessible.

What happens is:

  1. User tries to add link to text through the editor (Visual or HTML).
  2. User enters the correct URL into the URL field, and exits that field by hitting "tab".
  3. User begins typing the link title. Firefox browser UI helpfully suggests some similar titles.
  4. User sees a title they'd like to use, and hit the keyboard down arrow, thinking that this will select the correct title for them.
  5. What actually happens is that the first link listed below in the link to existing content gets selected. This overwrites what's been entered in the URL and title field.
  6. User says, WTF just happened.

Solutions:

  • Adding autocomplete="off" to these two form fields would prevent Firefox from displaying its autosuggestions. This might fix the problem, but feels kind of like a bandaid.
  • A keydown/keyup handler could be attached to each of the text input fields with event.stopPropagation could stop the ui keyboard behavior when typing into those fields.

Attachments (2)

21934.patch1.diff (836 bytes) - added by goldenapples 7 years ago.
Patch that unbinds keydown/keyup handlers while input fields are focused
21934.patch2.diff (999 bytes) - added by goldenapples 7 years ago.
Patch that adds autocomplete=off to form fields

Download all attachments as: .zip

Change History (9)

@goldenapples
7 years ago

Patch that unbinds keydown/keyup handlers while input fields are focused

@goldenapples
7 years ago

Patch that adds autocomplete=off to form fields

#1 @MikeHansenMe
7 years ago

  • Keywords 2nd-opinion added

When adding a link I am able to use my down arrow to select a previous title. I am using Ubuntu 12.04.1 and FireFox 15. I also tested in Chrome, it was a different experience. It did not show me any suggestions.

#2 @azaozz
6 years ago

  • Keywords ux-feedback added
  • Milestone changed from Awaiting Review to Future Release

Not sure it's a good idea to disable autocomplete for these fields. The user may be adding similar or the same URLs and titles several times.

Unbinding the down-arrow key while the fields are focused seems sensible. Generally a tab should highlight the first choice in the list of links and then the arrow keys should move the selection up/down, similarly to how a <select size="10"> works.

#3 @chriscct7
4 years ago

  • Focuses administration added
  • Keywords has-patch needs-refresh added; 2nd-opinion removed
  • Type changed from defect (bug) to enhancement

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


2 years ago

#5 @melchoyce
2 years ago

Is this still the case with the new link inserter?

This ticket was mentioned in Slack in #design by boemedia. View the logs.


17 months ago

#7 @melchoyce
17 months ago

  • Milestone Future Release deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Please reopen if this is still an issue.

Note: See TracTickets for help on using tickets.