#21936 closed defect (bug) (fixed)
.widefat select has a gray background, unlike inputs which are white
Reported by: | alexvorn2 | Owned by: | helen |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | minor | Version: | 3.4.2 |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | ui | Cc: |
Description
http://wpimpact.com/wp-content/uploads/2012/09/Untitled-2w.png
remove widefat class form select input tags in Widgets...
widefat class makes select element darker, like in Pages widget
Attachments (7)
Change History (32)
#3
in reply to:
↑ 1
@
12 years ago
Replying to helenyhou:
Would it make sense to just make the background for
.widefat
select elements white? It is for text-type inputs. I never really understood why it was a different color.
It seems that 'widefat' makes the select input wide, so removing the class is a bad idea, changing the color is a better one... thanks for suggestion!
#6
@
11 years ago
MikeHansenMe - Perhaps you meant to change the background rather than the border color?
#10
@
11 years ago
You don't need to patch the minified files - a post-commit bot takes care of it. Also, I think it may already have been the right color in this case, but changes in colors-fresh.css
often need a parallel change in colors-classic.css
(blue).
#11
@
11 years ago
I wondered about the min version but figured I would include it anyway. I think the color(f9f9f9) on color fresh is different from the other fields(fff). Color classic seems to match already.
#12
@
11 years ago
so is this good for 3.6 milestone? I thought that at 3.5 update this will be fixed :(
#13
@
11 years ago
- Summary changed from remove widefat class from widgets to .widefat select has a gray background, unlike inputs which are white
Have to figure out why it was that color in the first place before we can just change it.
#14
@
11 years ago
.widefat is used on the import page to style the table.
Maybe there should be another rule "select.widefat" just as there is a "textarea.widefat" or possible even a new class to use on input/select/textarea to reduce css. I think the original reason for this being used was just to get width: 100%;
#16
@
11 years ago
- Component changed from UI to Widgets
- Keywords has-patch added
- Milestone changed from Awaiting Review to 3.6
#17
@
11 years ago
Patch works, no unwanted side effects.
Update: did not work, I must have had another patch active. Reverted, tested again. being overwritten by CSS (my bad, need coffee).
#18
@
11 years ago
- Keywords ui-focus added
.widefat
has the background color defined in the color CSS files, with textarea.widefat
getting the background color treatment to override. I would suggest either putting the select.widefat
rule there, or to change the .widefat
declaration for border and background colors to table.widefat
.
#21
@
11 years ago
21936.5.diff removes what would be an unnecessary rule for textarea.widefat
. I tested around the admin and don't see any detrimental effects. The tag cloud widget has a select.widefat
, for an existing example.
#22
@
11 years ago
Nice, the text widget did use textarea.widefat but is now taking the width 100% from .widefat and background of #fff from the default textarea css rule. So it looks correct.
Would it make sense to just make the background for
.widefat
select elements white? It is for text-type inputs. I never really understood why it was a different color.