Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#21956 closed defect (bug) (fixed)

Long name in Page Template metabox breaks admin layout

Reported by: ov3rfly's profile Ov3rfly Owned by: nacin's profile nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.4
Component: UI Keywords: has-patch ui-feedback
Focuses: Cc:

Description

Long template names shown in Page Template metabox in admin interface break the layout to the right, see attachment.

Possible fix: "max-width" css for select id="page_template"

Attachments (4)

page-template-box-too-wide.png (5.0 KB) - added by Ov3rfly 12 years ago.
21956.patch (343 bytes) - added by ocean90 12 years ago.
21956.2.patch (1.1 KB) - added by SergeyBiryukov 12 years ago.
21956.3.patch (1.1 KB) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (13)

#1 @ocean90
12 years ago

Related: [18453]

Removed with [21042], see #19613

Last edited 12 years ago by ocean90 (previous) (diff)

@ocean90
12 years ago

#2 @ocean90
12 years ago

  • Cc SergeyBiryukov added
  • Component changed from Administration to UI
  • Keywords has-patch added
  • Version changed from 3.4.2 to 3.4

#3 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 3.5

Looks good. 21956.2.patch does the same in Quick Edit.

IE 7/8 requires fixed width (related: ticket:21752:3, also addressed in the patch).

Last edited 12 years ago by SergeyBiryukov (previous) (diff)

#4 @SergeyBiryukov
12 years ago

Tested in Firefox 15, Chrome 21, IE 7, IE 8, Opera 12.

#5 @nacin
12 years ago

For quick edit, we also have to account for the label when doing max-width: 100%. Something like max-width: 80% will account for the label except at much narrower widths.

#6 @SergeyBiryukov
12 years ago

21956.3.patch adds max-width: 80% for Quick Edit.

#7 @MikeHansenMe
12 years ago

  • Cc mdhansen@… added

Tested 21956.3.patch on Ubuntu with Chrome 20 and Firefox 16, did not test IE. Looks good for me.

#8 @SergeyBiryukov
12 years ago

  • Keywords ui-feedback added

#9 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22443:

Try to avoid overflow of the page template dropdown with long template names. props SergeyBiryukov, ocean90. fixes #21956.

Note: See TracTickets for help on using tickets.