Exporter doesn't exclude auto-drafts when calculating the authors list

[westi]

The exported correctly excludes auto-drafts from the file but not when calculating the list of authors on the blog.

This means the export file can have a list of authors which doesn't match those on the blog and can include users that might not be expected when the WordPress install has multisite enabled as auto-drafts can get created for Super Admins on other users blogs.

[westi]

Simple patch to fix this issue

[westi]

"Unit Tests" that can't be committed because the function is not testable.

[westi]

I wrote some tests for this (attached) but we can really use them at the moment because these functions are defined inside export_wp and that throws headers already sent errors and phpunit marks the test as having errors.

Ideally we should make these functions more globally available - the export includes are only included when we load export.php anyway.

[nacin]

Replying to westi:

I wrote some tests for this (attached) but we can really use them at the moment because these functions are defined inside export_wp and that throws headers already sent errors and phpunit marks the test as having errors.

Ideally we should make these functions more globally available - the export includes are only included when we load export.php anyway.

Yep, they should just be pulled into export.php. Defining functions inside functions is a pretty silly endeavor.

[westi]

In [21946]:

Export: Ignore auto-drafts when building the list of users for the export file. Fixes #21960.

[johnbillion]

Further enhancement to this: #20206 (albeit an older ticket)