404 error when a post has the same slug as with a deleted (trash) page.

[janintia]

I don't know if this is a bug/issue but I'll share this anyway.

A user creates a new Page, for example, with a title "New Garden". But decides to delete it/"Move to Trash" without deleting it permanently. Then creates a new Post with the same title "New Garden". Viewing that post will result to a "404" page not found.

[SergeyBiryukov]

Reproduced with /%postname%/ permalink structure.

[SergeyBiryukov]

Related: #21298

Perhaps get_page_by_path() should not return trashed pages.

[DrewAPicture]

Related: #11863 - Trashed items interfere with page/post slug generation

[SergeyBiryukov]

#22210 was marked as a duplicate.

[kovshenin]

Check the page post status before verifying a match

[kovshenin]

In ​21970.diff, verifying that the page has a visible post status (public, private or protected). I first thought of checking against the read_post cap, but that might create a really confusing scenario, where a logged in user will see the page, while a logged out user will see the post.

[SergeyBiryukov]

21970.diff​ looks good to me.

21970.2.diff​ also handles the similar block in url_to_postid().

[kovshenin]

Related: #11863

[SergeyBiryukov]

21970.3.diff​ makes the condition syntax a bit more obvious.

[sc0ttkclark]

A similar issue happens with get_page_by_title() (pulls from trash), I may be submitting a patch for that separately as well depending on dev feedback on whether core is open to the adjustment.

[SergeyBiryukov]

Replying to sc0ttkclark:

A similar issue happens with get_page_by_title() (pulls from trash)

Related: #20350

[markjaquith]

Punting this as we're focusing on 3.6 blockers now.

[SergeyBiryukov]

#24817 was marked as a duplicate.

[nacin]

This needs unit tests like whoa.

[SergeyBiryukov]

#30047 was marked as a duplicate.

[igmoweb]

Unit test

[igmoweb]

Added Unit Tests.

I didn't know where to place this one so I decided for tests/post/objects.php. Now that I read it again sounds weird for me :).

[SergeyBiryukov]

#33329 was marked as a duplicate.

[SergeyBiryukov]

Related: #13459, #24612.

[SergeyBiryukov]

In 35195:

In WP::parse_request() and url_to_postid(), if a post slug clashes with a trashed page, return the post instead of the page.

Props kovshenin, SergeyBiryukov, igmoweb.
Fixes #21970.

[ocean90]

[35195] produces a unit test failure:

$ phpunit --group rewrite

1) Tests_Query_VerbosePageRules::test_post_attachment
is_single, is_attachment, is_singular should be true. is_404 should be false.
Failed asserting that false is true.

/srv/www/wp-develop/svn/tests/phpunit/includes/testcase.php:550
/srv/www/wp-develop/svn/tests/phpunit/tests/query/conditionals.php:599

[SergeyBiryukov]

[35195] broke pretty permalinks for attachments (#1914), though accidentally fixed #24612 as a side effect.

[SergeyBiryukov]

21970.4.diff​ fixes it for me.

[SergeyBiryukov]

In 35205:

In WP::parse_request() and url_to_postid(), don't skip objects that have a post status with 'exclude_from_search' => false, e.g. inherit.

This fixes pretty permalinks for attachments, broken in [35195].

Fixes #21970.