WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #21973


Ignore:
Timestamp:
09/23/12 00:00:42 (2 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21973 – Description

    initial v1  
    11Current twenty twelve theme uses wp_enqueue_style for loading google fonts and it points to two bugs in wp_enqueue_style 
    22 
    3 1. it does not allow to add address without protocol. It is perfectly valid to use e.g. "//fonts.googleapis.com/css?family=Open+Sans:400italic,700italic,400,700" and it would load http when you are running it from http server or https if you are using https. If you put this to wp_enqueue_style, it deletes one "/" from the begining and then it try to load it from 'yourserver.tld/fonts.googleapis.com/' 
     31. it does not allow to add address without protocol. It is perfectly valid to use e.g. `//fonts.googleapis.com/css?family=Open+Sans:400italic,700italic,400,700`" and it would load http when you are running it from http server or https if you are using https. If you put this to wp_enqueue_style, it deletes one "/" from the begining and then it try to load it from 'yourserver.tld/fonts.googleapis.com/' 
    44 
    5 2. it has very funny and hard to notice bug for developers - when you are using with user logged on, it works OK. But when you are looking at the web logged off, it cut everything behind the ? char, so it will try to load 'http(s)://fonts.googleapis.com/css' and so in this case finishes with 404 
     52. it has very funny and hard to notice bug for developers - when you are using with user logged on, it works OK. But when you are looking at the web logged off, it cut everything behind the ? char, so it will try to load `http(s)://fonts.googleapis.com/css` and so in this case finishes with 404 
    66 
    77P.S.: i set it as a blocker, because future default theme twenty twelve uses this as default (what is wrong btw., see #21972)