WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 4 years ago

#21976 closed enhancement (wontfix)

Remove the "standard" fullscreen mode from the default configuration of TinyMCE

Reported by: azaozz Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: needs-patch
Focuses: Cc:
PR Number:

Description

The "standard" TinyMCE fullscreen is incompatible with the DFW fullscreen. Currently we are loading both plugins and trying to give access to the standard fullscreen by shortcut only. This is left over from when DFW was working only for the Edit Post screen.

Best would be to remove the standard fullscreen completely. It can be added by a simple WordPress plugin for users that prefer it.

Attachments (3)

21976.patch (5.9 KB) - added by azaozz 7 years ago.
21976-2.patch (14.5 KB) - added by azaozz 7 years ago.
add_mce_fullscreen.php (349 bytes) - added by azaozz 7 years ago.
Super simple plugin to add TinyMCE's fullscreen

Download all attachments as: .zip

Change History (20)

#1 @azaozz
7 years ago

The actual "fullscreen" TinyMCE plugin will still be included in WordPress as we use it in PressThis. It will be disabled by default in the "normal" editor and enabled in "teeny".

@azaozz
7 years ago

@azaozz
7 years ago

#2 @azaozz
7 years ago

Related: #21197.

21976-2.patch also includes some cleanup/refresh of the help popup in the visual editor.

@azaozz
7 years ago

Super simple plugin to add TinyMCE's fullscreen

#3 @navjotjsingh
7 years ago

  • Cc navjotjsingh@… added

#4 @helenyhou
7 years ago

  • Keywords has-patch needs-refresh added

#5 follow-up: @miqrogroove
7 years ago

I would like to see the shortcut hooked up to DFW rather than removed. If it's a conflict with TinyMCE, then could there be a new shortcut?

#6 in reply to: ↑ 5 @azaozz
7 years ago

Replying to miqrogroove:

Sure, the shortcut for DFW is Alt + Shift + W. As we used Alt + Shift + G for the MCE fullscreen, it would still work if the default fullscreen is added.

#7 @nacin
7 years ago

  • Keywords punt added

#8 @azaozz
7 years ago

Agree with @nacin. This seems to be working well for now. If/when we review DFW can look into it again.

#9 @azaozz
7 years ago

  • Milestone changed from 3.5 to Future Release

#10 @SergeyBiryukov
7 years ago

  • Keywords punt removed

#11 @pavelevap
6 years ago

One user wanted to write shortcode with shortcuts (Right ALT + F) but he was switched to TinyMCE Fullscreen mode.

#12 @iseulde
5 years ago

  • Keywords needs-patch added; has-patch needs-refresh removed
  • Milestone changed from Future Release to 4.2

Let's take a look at this with together with #30949.

This ticket was mentioned in Slack in #core by drew. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by drew. View the logs.


5 years ago

#15 @DrewAPicture
5 years ago

  • Milestone changed from 4.2 to Future Release

I'm inclined to punt this the same as #30949. Pretty late to consider removing something like this, imo. If a committer or a lead wants to own it, feel free re-milestone it.

This ticket was mentioned in Slack in #core-editor by iseulde. View the logs.


4 years ago

#17 @azaozz
4 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

After removing the old DFW, the "standard" fullscreen is the only one available fro editors other than the "main" editor on the Edit Post screen. Seems better to keep it.

Note: See TracTickets for help on using tickets.