Allow 0, NULL and empty string values for 'parent'.

[sam2kb]

We must allow 0, NULL and empty string values for 'parent' in wp_newTerm and wp_editTerm

[nacin]

I don't think this is major — the workaround is to simply not pass 'parent'.

But yes, switching from isset() to ! empty() makes sense.

[nacin]

Looks like test_parent_empty() will need to change, and probably be expanded a bit: ​http://unit-tests.trac.wordpress.org/browser/trunk/tests/xmlrpc/wp/editTerm.php. A similar test does not exist yet for wp/newTerm.

[nacin]

I think it is safe to call this a bug.

[markoheijnen]

Patch from root instead of wp-includes folder

[markoheijnen]

Changed unit tests for this patch

[markoheijnen]

Changed the unit tests and added extra ones to wp.editTerm and wp.newTerm. Also updated the patch of Sam to have it from the root instead of the wp-includes folder.

[nacin]

Does this patch allow for a term with a parent to be set to then have no parent?

[westi]

I'm not sure about this.

By definition the datatype that should be passed here is a string containing an integer, this is the return value of get_term and the new/edit functions should expect the same.

So ideally the correct value for parent is probably and empty string or '0' and all the tests should be updated to send numbers as strings.

I'm not sure ​[UT1118] adds completely correct tests.

[hrishiv90]

Modified patch for the parent reset of term via xmlrpc

[hrishiv90]

I have added modified patch solution which allows to reset the term parent to 0 (i.e no-parent), and also handles properly the null and empty values for parent.
https://core.trac.wordpress.org/attachment/ticket/21977/ticket.21977.2ndopnion.diff

[wonderboymusic]

In 34580:

XML-RPC: in wp_xmlrpc_server::wp_editTerm(), check ! empty when applying parent logic.

Adds unit tests.

Props hrishiv90, markoheijnen, sam2kb.
Fixes #21977.