WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#21985 closed defect (bug) (fixed)

Wrap .subsubsub for long list of views

Reported by: deltafactory Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: trivial Version: 3.5
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

The Views area of the WP List Table is styled not to wrap. This is a problem when the list of views is long. (e.g. an extended list of user roles on the Users page)

The following patch allows for wrapping while preventing wrapping within the <li> itself, so that the associated counter remains.

Most users should not notice a change to the appearance of this screen.

Attachments (8)

wp-admin.dev.css.patch (412 bytes) - added by deltafactory 3 years ago.
CSS patch for .subsubsub and .subsubsub li
views-before.png (13.1 KB) - added by deltafactory 3 years ago.
Views area before
views-after.png (13.2 KB) - added by deltafactory 3 years ago.
Views area after
wp-admin.css.patch (400 bytes) - added by deltafactory 3 years ago.
New patch file based on trunk, using renamed CSS file
chrome.png (21.7 KB) - added by ocean90 3 years ago.
21985.patch (329 bytes) - added by ocean90 3 years ago.
21985.2.patch (641 bytes) - added by SergeyBiryukov 3 years ago.
21985.3.patch (2.0 KB) - added by ocean90 2 years ago.
Refreshed

Download all attachments as: .zip

Change History (18)

@deltafactory3 years ago

CSS patch for .subsubsub and .subsubsub li

comment:1 @nacin3 years ago

A screenshot would help.

@deltafactory3 years ago

Views area before

@deltafactory3 years ago

Views area after

@deltafactory3 years ago

New patch file based on trunk, using renamed CSS file

comment:2 @deltafactory3 years ago

Screenshots added.

comment:3 @nacin3 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.5

comment:4 @nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21987]:

Avoid wrapping for individual .subsubsub view names, rather than the entire list of views, in case there are many. props deltafactory, fixes #21985.

@ocean903 years ago

@ocean903 years ago

comment:5 follow-up: @ocean903 years ago

  • Keywords commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Not quiet sure what's going on here, but [21987] breaks the list in Chrome @ OS X.

http://core.trac.wordpress.org/raw-attachment/ticket/21985/chrome.png

21985.patch fixes it for me.

Last edited 3 years ago by SergeyBiryukov (previous) (diff)

comment:6 @deltafactory3 years ago

@ocean90: Just curious, what was the behavior in OS X/Chrome before? Original no-wrap behavior, or something else?

@SergeyBiryukov3 years ago

comment:7 in reply to: ↑ 5 @SergeyBiryukov3 years ago

Replying to ocean90:

[21987] breaks the list in Chrome @ OS X.

Reproduced in Chrome on Windows as well.

Tested 21985.patch in Firefox 15, Chrome 22, IE 7, IE 8, Opera 12. IE 7 still needs display: inline (21985.2.patch), looks good otherwise.

comment:8 @Ipstenu2 years ago

21985.2.patch works for Chrome OS X too.

@deltafactory - It was the original no-wrap.

@ocean902 years ago

Refreshed

comment:9 @ocean902 years ago

  • Keywords commit added
  • Type changed from enhancement to defect (bug)

comment:10 @nacin2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 22404:

Use inline-block for wrapping filter links. props ocean90, SergeyBiryukov. fixes #21985.

Note: See TracTickets for help on using tickets.