Admin menu shadow inconsistencies

[nacin]

With the admin menu unfolded:

• Hovering over a top-level menu item without submenu items (Comments, or Plugins in multisite) should hide the shadow. This was the case from 3.2–3.4, but appears to have regressed in trunk.

With the admin menu folded:

• Hovering over a top-level menu item *with* submenu items should hide the shadow. This was the case from 3.2–3.4, but appears to have regressed in trunk.

• Hovering over a top-level menu item without submenu items (Comments) should hide the shadow. This is not a regression, but should be fixed for consistency.

Bonus:

The top-level items are a pixel or two taller when folded, making for a somewhat bouncy folding and unfolding experience.

[webord]

Here goes the patch for all the 2 regressions 1 consistency bug and the bonus (just one pixel taller).

Checked .auto-fold styles for consistency, needed to change some stuff there also.

[webord]

wp-admin.css

[helenyhou]

Two things I'm noticing with [21998.diff]:

• Current item does not get the arrow point if it does not have any submenu items (e.g. comments). It should have it.
• The icons shift down when the menu folds. It might have before as well, but now it's noticeable as nothing else shifts.

Everything else does seem to be addressed quite well.

[webord]

Thanks Helen,

Changes in the new patch

[helenyhou]

One last thing - current item does not have the arrow pointer when the menu is collapsed.

Another note - the reporter-feedback keyword is when asking the reporter of the ticket to give more feedback. ​More about keywords on Trac, if you're interested.

[webord]

It should have an Arrow pointer?

I never used collapsed menus, so I didn't know that.

[helenyhou]

You should be testing it against how it currently works. Nothing about how it currently works should be lost in addressing the bugs described in the ticket.

[webord]

Replying to helenyhou:
Problem Addressed

[helenyhou]

21998.3.diff​ works beautifully for me. Nice work, webord.

[DrewAPicture]

21998.3.diff​ looks good for me too.

[azaozz]

Is it just me or the menu icons are a bit lower when the menu is folded? Firefox, Chrome, IE9 on Win:

Also it needs some tweaks for RTL.

[helenyhou]

Replying to azaozz:

Is it just me or the menu icons are a bit lower when the menu is folded?

I tested OSX browsers and IE8 and they seemed to be in the same spot as when unfolded.

Working on RTL now - can't believe I forgot to check. Happy to have somebody beat me to the patch, though, if perhaps webord is interested in RTL-land.

[webord]

How can I test on RTL? I found this plugin, but is it the correct way to test RTL?

​http://wordpress.org/extend/plugins/rtl-tester/

[helenyhou]

I've never used the plugin myself, but I hear it works. I use a language instead (Arabic) so I get a full sense of the differences, but it's not necessary. I think azaozz may have a patch almost ready, though.

[azaozz]

In [22263]:

Adminmenu: fix folded height and shadow inconsistencies, props webord, fixes #21998

[azaozz]

Replying to webord:

How can I test on RTL?

On my test installs I have this in wp-config.php:

if ( !empty($_GET['rtl']) )
	$text_direction = 'rtl';

To go to RTL you just add ?rtl=1 or &rtl=1 to any url.

[nacin]

Is it just me or the menu icons are a bit lower when the menu is folded?

azaozz, it isn't just you. But your browser must be narrow enough to trigger the auto-fold. If your window gets just wide enough to stop auto-folding but you still have it collapsed, the collapsed menu will shrink slightly in height.

There are other inconsistencies at the auto-fold width that were fixed at the normal width: ​http://cl.ly/image/393I0C0p0z2s and ​http://cl.ly/image/1w3Q3X1U273y, in both cases there should be no shadow there.

[azaozz]

In 22536:

Admin menu: sync the .folded and @media .auto-fold styles, fixes #21998