WordPress.org

Make WordPress Core

#21998 closed defect (bug) (fixed)

Admin menu shadow inconsistencies

Reported by: nacin Owned by: azaozz
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Administration Keywords: needs-patch
Focuses: Cc:

Description

With the admin menu unfolded:

  • Hovering over a top-level menu item without submenu items (Comments, or Plugins in multisite) should hide the shadow. This was the case from 3.2–3.4, but appears to have regressed in trunk.

With the admin menu folded:

  • Hovering over a top-level menu item *with* submenu items should hide the shadow. This was the case from 3.2–3.4, but appears to have regressed in trunk.
  • Hovering over a top-level menu item without submenu items (Comments) should hide the shadow. This is not a regression, but should be fixed for consistency.

Bonus:

The top-level items are a pixel or two taller when folded, making for a somewhat bouncy folding and unfolding experience.

Attachments (4)

21998.diff (2.6 KB) - added by webord 22 months ago.
wp-admin.css
21998.2.diff (2.9 KB) - added by webord 21 months ago.
21998.3.diff (3.0 KB) - added by webord 21 months ago.
folded.png (26.0 KB) - added by azaozz 21 months ago.

Download all attachments as: .zip

Change History (25)

comment:1 helenyhou22 months ago

  • Keywords needs-patch added

comment:2 webord22 months ago

  • Cc webord.net@… added

comment:3 deltafactory22 months ago

  • Cc jeff@… added

comment:4 webord22 months ago

  • Keywords has-patch dev-feedback added; needs-patch removed

Here goes the patch for all the 2 regressions 1 consistency bug and the bonus (just one pixel taller).

Checked .auto-fold styles for consistency, needed to change some stuff there also.

webord22 months ago

wp-admin.css

comment:5 helenyhou21 months ago

  • Keywords needs-patch added; has-patch dev-feedback removed

Two things I'm noticing with [21998.diff]:

  • Current item does not get the arrow point if it does not have any submenu items (e.g. comments). It should have it.
  • The icons shift down when the menu folds. It might have before as well, but now it's noticeable as nothing else shifts.

Everything else does seem to be addressed quite well.

Last edited 21 months ago by helenyhou (previous) (diff)

webord21 months ago

comment:6 webord21 months ago

  • Keywords has-patch dev-feedback reporter-feedback added; needs-patch removed

Thanks Helen,

Changes in the new patch

comment:7 helenyhou21 months ago

  • Keywords needs-patch added; has-patch dev-feedback reporter-feedback removed

One last thing - current item does not have the arrow pointer when the menu is collapsed.

Another note - the reporter-feedback keyword is when asking the reporter of the ticket to give more feedback. More about keywords on Trac, if you're interested.

comment:8 webord21 months ago

It should have an Arrow pointer?

I never used collapsed menus, so I didn't know that.

comment:9 follow-up: helenyhou21 months ago

You should be testing it against how it currently works. Nothing about how it currently works should be lost in addressing the bugs described in the ticket.

webord21 months ago

comment:10 in reply to: ↑ 9 webord21 months ago

  • Keywords has-patch added; needs-patch removed

Replying to helenyhou:
Problem Addressed

comment:11 webord21 months ago

  • Keywords dev-feedback added

comment:12 helenyhou21 months ago

  • Keywords commit added; dev-feedback removed

21998.3.diff works beautifully for me. Nice work, webord.

comment:13 DrewAPicture21 months ago

21998.3.diff looks good for me too.

azaozz21 months ago

comment:14 follow-up: azaozz21 months ago

Is it just me or the menu icons are a bit lower when the menu is folded? Firefox, Chrome, IE9 on Win:


Also it needs some tweaks for RTL.

Last edited 21 months ago by azaozz (previous) (diff)

comment:15 in reply to: ↑ 14 helenyhou21 months ago

  • Keywords needs-patch added; has-patch commit removed

Replying to azaozz:

Is it just me or the menu icons are a bit lower when the menu is folded?

I tested OSX browsers and IE8 and they seemed to be in the same spot as when unfolded.

Working on RTL now - can't believe I forgot to check. Happy to have somebody beat me to the patch, though, if perhaps webord is interested in RTL-land.

comment:16 follow-up: webord21 months ago

How can I test on RTL? I found this plugin, but is it the correct way to test RTL?

http://wordpress.org/extend/plugins/rtl-tester/

comment:17 helenyhou21 months ago

I've never used the plugin myself, but I hear it works. I use a language instead (Arabic) so I get a full sense of the differences, but it's not necessary. I think azaozz may have a patch almost ready, though.

comment:18 azaozz21 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [22263]:

Adminmenu: fix folded height and shadow inconsistencies, props webord, fixes #21998

comment:19 in reply to: ↑ 16 azaozz21 months ago

Replying to webord:

How can I test on RTL?

On my test installs I have this in wp-config.php:

if ( !empty($_GET['rtl']) )
	$text_direction = 'rtl';

To go to RTL you just add ?rtl=1 or &rtl=1 to any url.

comment:20 nacin20 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Is it just me or the menu icons are a bit lower when the menu is folded?

azaozz, it isn't just you. But your browser must be narrow enough to trigger the auto-fold. If your window gets just wide enough to stop auto-folding but you still have it collapsed, the collapsed menu will shrink slightly in height.

There are other inconsistencies at the auto-fold width that were fixed at the normal width: http://cl.ly/image/393I0C0p0z2s and http://cl.ly/image/1w3Q3X1U273y, in both cases there should be no shadow there.

comment:21 azaozz20 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 22536:

Admin menu: sync the .folded and @media .auto-fold styles, fixes #21998

Note: See TracTickets for help on using tickets.