Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#22000 closed defect (bug) (fixed)

"Reply and Approve" should approve parent comment first

Reported by: nacin Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Comments Keywords: easy-fix has-patch commit
Focuses: Cc:

Description (last modified by nacin)

"Reply and Approve" should approve parent comment first. If you receive a stream of updates (emails, jabber, etc.), you'd end up with the comments out of order.

Fairly simple fix — take the block in wp_ajax_replyto_comment() that starts with "automatically approve parent comment" and move it above the wp_new_comment() call.

If for some reason wp_new_comment() fails (as we account for currently, minimally), we should probably just let the parent comment stand as approved, no need to try to revert.

Attachments (1)

22000.patch (1.2 KB) - added by trepmal 6 years ago.

Download all attachments as: .zip

Change History (5)

#1 @nacin
6 years ago

  • Description modified (diff)

6 years ago

#2 @trepmal
6 years ago

  • Keywords has-patch added; needs-patch removed

#3 @nacin
6 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.5

#4 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22370:

When approving and then replying to a comment, approve the parent comment before inserting the reply. props trepmal, fixes #22000.

Note: See TracTickets for help on using tickets.