WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#22005 closed enhancement (fixed)

Twenty Thirteen: remove custom comment callback in favor of core `comment_form()` defaults

Reported by: lancewillett Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Related to improvements to core comment form markup, see #20088.

Notes:

  • We might need to remove the Post Author span element from the output, and use CSS instead to denote the post author's comments (background color, border, etc)
  • Twenty Twelve should be styled to work well with 3.4 comment form output (not just with the new #20088 output)
  • Use comment_form() arguments so that plugins and child themes can override anything

Attachments (2)

22005.first-pass.diff (10.3 KB) - added by obenland 4 years ago.
22005.1.diff (5.5 KB) - added by obenland 3 years ago.

Download all attachments as: .zip

Change History (17)

#1 @lancewillett
4 years ago

  • Milestone changed from 3.5 to Future Release

Discussing in IRC dev chat yesterday, punting this to Twenty Twelve 1.1 but still intending to get it in before 3.5 stable hits.

#2 @nacin
4 years ago

  • Milestone changed from Future Release to 3.5

#3 in reply to: ↑ description ; follow-up: @obenland
4 years ago

Replying to lancewillett:

  • We might need to remove the Post Author span element from the output, and use CSS instead to denote the post author's comments (background color, border, etc)

I think we might be able to just append it to the get_comment_author_link() output.


  • Twenty Twelve should be styled to work well with 3.4 comment form output (not just with the new #20088 output)
  • Use comment_form() arguments so that plugins and child themes can override anything

How is twentytwelve_comment() related to comment_form()? Did you mean wp_list_comments()?

#4 in reply to: ↑ 3 @lancewillett
4 years ago

Replying to obenland:

  • Use comment_form() arguments so that plugins and child themes can override anything

How is twentytwelve_comment() related to comment_form()? Did you mean wp_list_comments()?

Yep, my mistake.

#5 @obenland
4 years ago

22005.first-pass.diff makes comment styling work with default 3.4 wp_list_comments() output. Actual call would be wp_list_comments( array( 'avatar_size' => 44 ) );

#6 @nacin
4 years ago

This would have been nice. What's the verdict? Doable? Not doable?

#7 @bpetty
4 years ago

I was looking over this one yesterday, and it seem like whatever is decided with #20088 is going to affect this ticket, maybe enough so that it's a dependency, so I figured since #20088 was just punted, this one probably should be too.

#8 @lancewillett
4 years ago

  • Milestone 3.5 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I agree with bpetty, this is too dependent on #20088 and not doable for 3.5 after all. Let's shoot for Twenty Thirteen not having a custom comment list function at all, out of the gate.

Last edited 3 years ago by lancewillett (previous) (diff)

#9 @bpetty
4 years ago

  • Cc bpetty added
  • Milestone set to 3.6
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Well, it looks like Twenty Thirteen didn't make it out of the gate without it's own custom comment list function.

#10 @lancewillett
4 years ago

bpetty -- why did you open this ticket? It's for Twenty Twelve.

#11 @lancewillett
4 years ago

  • Summary changed from Twenty Twelve: remove twentytwelve_comment() in favor of core comment_form() defaults to Twenty Thirteen: remove custom comment callback in favor of core `comment_form()` defaults

#12 @lancewillett
3 years ago

  • Keywords needs-refresh added

Noting for next steps: once #20088 change is in core, we can update the patch here for Twenty Thirteen.

  • Remove the custom callback
  • Add the new html5 argument to wp_list_comments()
  • Adjust any CSS to style the output from core

@obenland
3 years ago

#13 @obenland
3 years ago

  • Keywords has-patch added; needs-patch needs-refresh removed

#14 @lancewillett
3 years ago

Love seeing all the red in .1 patch. ;)

#15 @lancewillett
3 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from reopened to closed

In 23696:

Twenty Thirteen: remove custom comment callback in favor of core comment_form() defaults. Props obenland, closes #22005. See #20088.

Note: See TracTickets for help on using tickets.