WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#22016 closed defect (bug) (fixed)

Twenty Twelve .pot file and localization

Reported by: pavelevap's profile pavelevap Owned by: nacin's profile nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

1) Theme tags are in .pot file even if not visible. See ​https://make.wordpress.org/polyglots/2012/09/24/should-theme-tags-be-translated/ We should remove them from .pot file (and also for older themes).

2) Page Templates are not available for translation in .pot file. Probably makepot.php is not ready for Twenty Twelve because everything works well for older themes (for example Twenty Eleven).

3) There are 3 similar strings:

  • Sorry, but nothing matched your search criteria. Please try again with some different keywords.
  • Apologies, but no results were found. Perhaps searching will help find a related post.
  • Apologies, but no results were found for the requested archive. Perhaps searching will help find a related post.

Maybe they can be reduced?

Change History (10)

#1 @knutsp
12 years ago

  • Cc knut@… added

#2 @lancewillett
12 years ago

  • Milestone changed from Awaiting Review to 3.5

#3 @lancewillett
12 years ago

In [22061]:

Twenty Twelve: consolidate "Apologies" strings, see #22016.

#4 @lancewillett
12 years ago

  1. is done, the search string should stay the same but the other two are merged now.

For 1 and 2 I'll defer to the core i18n team for how to fix. They should probably be split out into 2 separate tickets from this one.

#5 @nacin
12 years ago

  • Owner set to nacin
  • Status changed from new to assigned

#6 @nacin
12 years ago

Page templates are left out because makepot.php (more accurately, pot-ext-meta.php) doesn't look in subdirectories. I'll get that fixed.

I'll get tags removed.

#7 @nacin
12 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [22067]:

Add page templates to the Twenty Twelve POT file. Remove tags from theme POT files. fixes #22016.

#8 follow-up: @pavelevap
12 years ago

Nice, thank you. Translators are satisfied :-)

I localized the whole theme and did not notice any other problem.

I only realized that removing Theme Tags from older WP branches is probably not the best idea, because in older WP versions these Tags were visible and localized... But nevermind, users should update...

#9 in reply to: ↑ 8 @nacin
12 years ago

Replying to pavelevap:

Nice, thank you. Translators are satisfied :-)

I localized the whole theme and did not notice any other problem.

I only realized that removing Theme Tags from older WP branches is probably not the best idea, because in older WP versions these Tags were visible and localized... But nevermind, users should update...

Visible, but never localized. Theme headers weren't localized until WP_Theme in 3.4.

#10 @pavelevap
12 years ago

Ooops, you are right!

Note: See TracTickets for help on using tickets.