WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#22018 closed defect (bug) (fixed)

Unexpected "Save Changes" button in "old" media uploader

Reported by: tobiasbg's profile TobiasBg Owned by: nacin's profile nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description

When clicking on the "Insert/Upload" button (next to the new/temporary "Beta Media" button) on any post edit screen, I have a "Save Changes" button right above the "Add media files from your computer" heading on the "From Computer" tab, that has not been there in WP 3.4.2, and that doesn't really make sense until something was uploaded.

Attachments (1)

22018.diff​ (472 bytes) - added by helenyhou 13 years ago.

Download all attachments as: .zip

Change History (7)

#1 @TobiasBg
13 years ago

Further investigation: The button (coming from ​here) does have a class "hidden", so likely some CSS that should actually hide the button is gone.

#2 @SergeyBiryukov
13 years ago

  • Component changed from General to Media
  • Milestone changed from Awaiting Review to 3.5

@helenyhou
13 years ago

#3 @helenyhou
13 years ago

  • Component changed from Media to UI
  • Keywords has-patch added

.button has display: inline-block, which is overriding the display: none for .hidden. Not sure what the best thing to do is - .button.hidden maybe? 22018.diff​ for that.

#4 @sabreuse
13 years ago

Patch works for me

#5 @lessbloat
13 years ago

  • Keywords commit added

+1 to 22018.diff.

#6 @nacin
13 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22440:

Allow the .hidden class to hide a button. props helenyhou. fixes #22018.

Note: See TracTickets for help on using tickets.