Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#22019 closed enhancement (fixed)

Twenty Twelve: wrong math in style.css rem example

Reported by: tomasm's profile TomasM Owned by: lancewillett's profile lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Bundled Theme Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

22	$rembase:     14;
23	$line-height: 24;
24	
25	---------- Examples

31	* Set a font-size and then set a line-height based on the font-size
32	        font-size: 16px
33	        font-size: 1.142857143rem; (16 / $rembase)
34	        line-height: 1.846153846; ($line-height / 16)

line-height = $line-height: 24 / 16 = 1.5

Or I'm wrong? How can we get 1.846153846?

Change History (6)

#1 in reply to: ↑ description @TomasM
12 years ago

  • Summary changed from Twenty Ten - wrong math in style.css rem example to Twenty Twelve - wrong math in style.css rem example

Sorry I had in mind Twenty Twelve.

#2 @SergeyBiryukov
12 years ago

  • Description modified (diff)
  • Summary changed from Twenty Twelve - wrong math in style.css rem example to Twenty Twelve: wrong math in style.css rem example

#3 @lancewillett
12 years ago

  • Milestone changed from Awaiting Review to 3.5

#4 @DrewAPicture
12 years ago

  • Cc xoodrew@… added

After talking to @lancewillett a little more about this I'm gonna go with the example being wrong. We'll need to find out if the 24 baseline was intended to be absolute.

#5 @lancewillett
12 years ago

  • Keywords dev-feedback removed

Talked it over with @drewstrojny (the other Drew!) and he confirmed it's a math mistake, the values throughout the stylesheet are correct.

#6 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [22069]:

Twenty Twelve: fix incorrect math in style.css rem example calculation, props TomasM. Closes #22019.

Note: See TracTickets for help on using tickets.