WordPress.org

Make WordPress Core

Opened 19 months ago

Closed 17 months ago

Last modified 17 months ago

#22021 closed task (blessed) (fixed)

Integrate new media workflow into QuickPress

Reported by: koopersmith Owned by: azaozz
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: needs-patch
Focuses: Cc:

Description

QuickPress calls media_buttons() and has a textarea, which means that the new media workflow should Just Work. Right now, it doesn't. Let's fix that.

Change History (9)

comment:1 nacin19 months ago

In [22072], by koopersmith:

Add QuickPress support for new media workflow.

  • Adds the code required to include the new media scripts, styles, and settings to media_button().
  • Improves script dependencies, namely making media-upload require media-views.
  • Some CSS tweaks for the making the new button work well with QuickPress.

see #21390, fixes #22021.

comment:2 nacin19 months ago

  • Resolution set to fixed
  • Status changed from new to closed

[22072] is top-notch. Big step towards back compat.

comment:3 ocean9018 months ago

  • Keywords needs-patch added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Seems like it's broken again.

comment:4 nacin18 months ago

#22255 — Beta Media button disabled after publishing QuickPress post

comment:5 azaozz17 months ago

There is a Quicktags instance for replying to comments on the dashboard and it uses wp_editor(). However QuickPress doesn't use wp_editor() so there's no JS to set wpActiveEditor for it. Adding a little JS to fix that.

comment:6 azaozz17 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from reopened to closed

In 22517:

QuickPress: add some JS to set wpActiveEditor when the title or content is focused, fixes #22021

comment:7 follow-up: koopersmith17 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Setting wpActiveEditor only on focus is insufficient — the "Add Media" button can be clicked without focusing either field. Also, we can simplify the selectors a bit, as well as leverage event delegation.

comment:8 koopersmith17 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 22542:

Media in QuickPress: Ensure wpActiveEditor is set when the "Add Media" button is clicked. fixes #22021, see #21390.

comment:9 in reply to: ↑ 7 azaozz17 months ago

Replying to koopersmith:

Nice catch. Keep forgetting thet focusin is normalized in jQuery (it's not supported in Firefox).

Note: See TracTickets for help on using tickets.