WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#22034 closed defect (bug) (fixed)

extra_tablenav change button on wp-users-list-table doesn't match wp-list-tables bulk actions button

Reported by: c3mdigital's profile c3mdigital Owned by: nacin's profile nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: UI Keywords: has-patch
Focuses: Cc:

Description

In class-wp-users-list-table the extra_table_nav change button has the button small class and doesn't match the ui of the parent class bulk actions submit button.

This was reported on the dot org alpha/beta support forums, ​http://wordpress.org/support/topic/misaligned-button-users?replies=1

Attachments (3)

22034.patch​ (563 bytes) - added by c3mdigital 12 years ago.
Changes class from small to action on extra table nav button
22034-2.patch​ (885 bytes) - added by lessbloat 12 years ago.
22034-3.patch​ (563 bytes) - added by lessbloat 12 years ago.

Download all attachments as: .zip

Change History (9)

@c3mdigital
12 years ago

Changes class from small to action on extra table nav button

#1 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 3.5

#2 @SergeyBiryukov
12 years ago

Screenshot (from the topic): ​http://i47.tinypic.com/234f38.jpg

The class was changed to 'button-small' in [21789], used to be 'button-secondary'.

@lessbloat
12 years ago

#3 @lessbloat
12 years ago

Swapped 'button' out for 'action', and added margin-top: 1px; in 22034-2.patch.

#4 @SergeyBiryukov
12 years ago

The margin-top part should probably be merged with ticket:21598:21598-tushie.diff​.

@lessbloat
12 years ago

#5 @lessbloat
12 years ago

Removed the margin-top bit in 22034-3.patch.

#6 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22423:

Fix the 'Change' button in the users list table. props c3mdigital. fixes #22034.

Note: See TracTickets for help on using tickets.