Make WordPress Core

Opened 14 years ago

Closed 14 years ago

Last modified 10 years ago

#22045 closed defect (bug) (worksforme)

TinyMCE button & media bar integration is broken with 3.5beta1 when visual editor is enabled

Reported by: harmr's profile harmr Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.5
Component: TinyMCE Keywords:
Focuses: Cc:

Description

My plugin "Leaflet Maps Marker" adds an icon to the media bar and to the TinyMCE bar in visual mode and a plain button in html mode.
This integration is partly broken since WordPress 3.5alpha and can also be reproduced in 3.5beta1. Although debug is turned on, I only
get the console output - which unfortunately doesnt help me in locating the problem:

Failed to load: http://beta.mapsmarker.com/wp-content/plugins/leaflet-maps-marker/ 
http://beta.mapsmarker.com/wp-includes/js/tinymce/tiny_mce.js?ver=356-21964 (Zeile 1)

Steps to reproduce:

  • install and activate the plugin "Leaflet Maps Marker"
  • check if visual editor is enabled in your profile
  • go to post or page edit screen
  • tinymce-bar doesnt get displayed

If you disable the visual editor in your profile and open post or page edit screen, the media icon and the "insert map"-button as quicktag work as designed

The tinymce-code gets called via the following code in my plugin:

    if ( isset($lmm_options['misc_tinymce_button']) && ($lmm_options['misc_tinymce_button'] == 'enabled') ) {
        require_once( plugin_dir_path( __FILE__ ) . 'inc' . DIRECTORY_SEPARATOR . 'tinymce-plugin.php' );
    }

the code for tinymce_plugin.php can be found on github: https://github.com/robertharm/Leaflet-Maps-Marker/blob/dev/inc/tinymce-plugin.php

any help for solving this incompatibility is appreciated!

Change History (7)

#1 @c3mdigital
14 years ago

  • Keywords reporter-feedback added; needs-patch removed
  • Severity changed from major to normal

I'm pretty sure your problems are due to how your registering and enqueuing your scripts. Your css also breaks the new admin buttons. There is no reason you should be changing default WordPress UI styling in your plugin.

You also are loading jQuery from google which is already 2 versions out of date from trunk. On my post edit screen with script_debug enabled I'm getting built in jQuery then yours overrides. TinyMce advanced works fine in 3.5beta. Please provide a way to verify this bug without having to install your whole plugin. if you can verify the bug cleanly.

#2 @harmr
14 years ago

thanks for the hint with jquery 1.8.0 vs 1.8.2 - I updated to 1.8.2 but unfortunately with no effect. Problem is, that I didnt write this code by myself so I dont know exactly where to start. If you have any more tipps what to check/change, I´d be happy to know about it!

#3 @harmr
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I found a solution - had to base64_encode() links in registered scripts & now it works again :-)

#4 @c3mdigital
14 years ago

  • Keywords reporter-feedback removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

#5 @c3mdigital
14 years ago

  • Resolution set to worksforme
  • Status changed from reopened to closed

#6 @ocean90
13 years ago

  • Milestone Awaiting Review deleted

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


10 years ago

Note: See TracTickets for help on using tickets.